Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Brendan Heading <brendanheading@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 1/1] package/gdb: host-texinfo needed for full gdb
Date: Tue,  8 Sep 2015 20:27:23 +0100	[thread overview]
Message-ID: <1441740443-7280-1-git-send-email-brendanheading@gmail.com> (raw)

Fixes :
http://autobuild.buildroot.net/results/dd5/dd50ed99abb2c8495def826866b184030953f90e/

.. and many others.

when building the full gdb (ie not just gdbserver) on the host or target
the "make install" phase seems to expect makeinfo (from texinfo) to be
present.

Added a dependency so that the host always depends on host-texinfo, and
the target depends on it if the full GDB is being built. No need to set
ac_cv_prog_MAKEINFO anymore as it doesn't seem to achieve the desired
effect.

Signed-off-by: Brendan Heading <brendanheading@gmail.com>
---
v1->v2: fixed for target, removed duplication in gdb.mk. Used better
subject suggested by Vicente.

v2->v3: fix typos, fixed subject to reflect that the issue applies to
gdb in general (host and target).
---
 package/gdb/gdb.mk | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/package/gdb/gdb.mk b/package/gdb/gdb.mk
index 338de20..3114fd4 100644
--- a/package/gdb/gdb.mk
+++ b/package/gdb/gdb.mk
@@ -33,7 +33,8 @@ ifeq ($(BR2_PACKAGE_GDB_DEBUGGER),)
 GDB_SUBDIR = gdb/gdbserver
 HOST_GDB_SUBDIR = .
 else
-GDB_DEPENDENCIES = ncurses \
+# need makeinfo if building the full debugger
+GDB_DEPENDENCIES = ncurses host-texinfo \
 	$(if $(BR2_PACKAGE_LIBICONV),libiconv)
 endif
 
@@ -165,14 +166,8 @@ else
 HOST_GDB_CONF_OPTS += --without-python
 endif
 
-ifeq ($(GDB_FROM_GIT),y)
-GDB_DEPENDENCIES += host-texinfo
+# since we always build the full GDB on the host, texinfo/makeinfo is required
 HOST_GDB_DEPENDENCIES += host-texinfo
-else
-# don't generate documentation
-GDB_CONF_ENV += ac_cv_prog_MAKEINFO=missing
-HOST_GDB_CONF_ENV += ac_cv_prog_MAKEINFO=missing
-endif
 
 # legacy $arch-linux-gdb symlink
 define HOST_GDB_ADD_SYMLINK
-- 
2.4.3

             reply	other threads:[~2015-09-08 19:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-08 19:27 Brendan Heading [this message]
2015-09-08 21:50 ` [Buildroot] [PATCH v3 1/1] package/gdb: host-texinfo needed for full gdb Arnout Vandecappelle
2015-09-08 22:02   ` Brendan Heading
2015-09-08 22:09   ` Romain Naour
2015-09-08 22:29     ` Arnout Vandecappelle
2015-09-09  9:04       ` Vicente Olivert Riera
2015-09-09  9:51   ` Thomas Petazzoni
2015-09-09  9:18 ` Vicente Olivert Riera
2015-09-11 17:34 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1441740443-7280-1-git-send-email-brendanheading@gmail.com \
    --to=brendanheading@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox