From: David du Colombier <0intro@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/1] wpa_supplicant: fix static link with readline
Date: Sun, 13 Sep 2015 23:50:36 +0200 [thread overview]
Message-ID: <1442181036-4119-1-git-send-email-0intro@gmail.com> (raw)
When linking statically, the order of libraries on the
linker command matters, since readline depends on ncurses.
Signed-off-by: David du Colombier <0intro@gmail.com>
---
.../0005-fix-readline-libs-ordering.patch | 24 ++++++++++++++++++++++
1 file changed, 24 insertions(+)
create mode 100644 package/wpa_supplicant/0005-fix-readline-libs-ordering.patch
diff --git a/package/wpa_supplicant/0005-fix-readline-libs-ordering.patch b/package/wpa_supplicant/0005-fix-readline-libs-ordering.patch
new file mode 100644
index 0000000..ae7cf9e
--- /dev/null
+++ b/package/wpa_supplicant/0005-fix-readline-libs-ordering.patch
@@ -0,0 +1,24 @@
+commit 631f0893038743cebd2def39df61aceb48bd43a9
+Author: David du Colombier <0intro@gmail.com>
+Date: Sun Sep 13 23:40:43 2015 +0200
+
+ wpa_supplicant: fix static link with readline
+
+ The readline library depends on ncurses, so
+ it should be set before ncurses on the linker
+ command line to be able to be statically linked
+ successfully.
+
+diff --git a/wpa_supplicant/Makefile b/wpa_supplicant/Makefile
+index 1597412..581db02 100644
+--- a/wpa_supplicant/Makefile
++++ b/wpa_supplicant/Makefile
+@@ -1408,7 +1408,7 @@ LIBS += $(DBUS_LIBS)
+
+ ifdef CONFIG_READLINE
+ OBJS_c += ../src/utils/edit_readline.o
+-LIBS_c += -lncurses -lreadline
++LIBS_c += -lreadline -lncurses
+ else
+ ifdef CONFIG_WPA_CLI_EDIT
+ OBJS_c += ../src/utils/edit.o
--
1.8.3.1
reply other threads:[~2015-09-13 21:50 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1442181036-4119-1-git-send-email-0intro@gmail.com \
--to=0intro@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox