Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ryan Barnett <ryanbarnett3@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [v2 1/1] make: disable guile support when static linking enabled
Date: Sun, 20 Sep 2015 16:10:30 -0500	[thread overview]
Message-ID: <1442783430-26199-1-git-send-email-ryanbarnett3@gmail.com> (raw)

When building in a static only configuration with guile package
enabled, the following error happens:

 gc_pthread_redirects.h:37:22: fatal error: dlfcn.h: No such file or
 directory
   #   include <dlfcn.h>

The file gc_pthread_redirects.h comes from bdwgc, which gets built
before make in the autobuild test case you're pointing to. This header
file is known to incorrectly include <dlfcn.h>, unless GC_NO_DLOPEN is
specified.

IF GC_NO_DLOPEN is defined, another issue arises due to libguile and
libintl both defining locale_charset.

Thus disable guile support for make.

Fixes:
  http://autobuild.buildroot.net/results/814/8143ae0afac139845e5016058d85c800dc8527ad

Signed-off-by: Ryan Barnett <ryanbarnett3@gmail.com>
---
 package/make/make.mk | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/package/make/make.mk b/package/make/make.mk
index ebfa2f0..20702dc 100644
--- a/package/make/make.mk
+++ b/package/make/make.mk
@@ -11,16 +11,11 @@ MAKE_DEPENDENCIES = $(if $(BR2_NEEDS_GETTEXT_IF_LOCALE),gettext)
 MAKE_LICENSE = GPLv3+
 MAKE_LICENSE_FILES = COPYING
 
+MAKE_CONF_OPTS = --without-guile
+
 # Disable the 'load' operation for static builds since it needs dlopen
 ifeq ($(BR2_STATIC_LIBS),y)
 MAKE_CONF_OPTS += --disable-load
 endif
 
-ifeq ($(BR2_PACKAGE_GUILE),y)
-MAKE_DEPENDENCIES += guile
-MAKE_CONF_OPTS += --with-guile
-else
-MAKE_CONF_OPTS += --without-guile
-endif
-
 $(eval $(autotools-package))
-- 
1.9.1

             reply	other threads:[~2015-09-20 21:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-20 21:10 Ryan Barnett [this message]
2015-09-20 21:51 ` [Buildroot] [v2 1/1] make: disable guile support when static linking enabled Yann E. MORIN
2015-09-20 22:00   ` Ryan Barnett
2015-09-21 17:25     ` Yann E. MORIN
2015-10-12 21:57 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1442783430-26199-1-git-send-email-ryanbarnett3@gmail.com \
    --to=ryanbarnett3@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox