Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Boeckel <mathstuf@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] makefile: remove LD_LIBRARY_PATH from the environment
Date: Wed, 28 Oct 2015 22:48:15 -0400	[thread overview]
Message-ID: <1446086895-28252-1-git-send-email-mathstuf@gmail.com> (raw)
In-Reply-To: <1445722754-3477-1-git-send-email-mathstuf@gmail.com>

If system tools are selected, the host's lib/ directory may shadow
libraries from the system which are configured differently and do not
have all of the symbols required by the system tool.

Since buildroot uses rpath everywhere, LD_LIBRARY_PATH should not be
necessary anyways.

Signed-off-by: Ben Boeckel <mathstuf@gmail.com>
---
 package/Makefile.in | 2 --
 1 file changed, 2 deletions(-)

diff --git a/package/Makefile.in b/package/Makefile.in
index 8a592d4..10f3a47 100644
--- a/package/Makefile.in
+++ b/package/Makefile.in
@@ -298,12 +298,10 @@ HOST_CONFIGURE_OPTS = \
 	PKG_CONFIG="$(PKG_CONFIG_HOST_BINARY)" \
 	PKG_CONFIG_SYSROOT_DIR="/" \
 	PKG_CONFIG_LIBDIR="$(HOST_DIR)/usr/lib/pkgconfig:$(HOST_DIR)/usr/share/pkgconfig" \
-	LD_LIBRARY_PATH="$(HOST_DIR)/usr/lib$(if $(LD_LIBRARY_PATH),:$(LD_LIBRARY_PATH))" \
 	INTLTOOL_PERL=$(PERL)
 
 HOST_MAKE_ENV = \
 	PATH=$(BR_PATH) \
-	LD_LIBRARY_PATH="$(HOST_DIR)/usr/lib$(if $(LD_LIBRARY_PATH),:$(LD_LIBRARY_PATH))" \
 	PKG_CONFIG="$(PKG_CONFIG_HOST_BINARY)" \
 	PKG_CONFIG_SYSROOT_DIR="/" \
 	PKG_CONFIG_LIBDIR="$(HOST_DIR)/usr/lib/pkgconfig"
-- 
2.6.2

  parent reply	other threads:[~2015-10-29  2:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-24 21:39 [Buildroot] [PATCH 0/1] Build host-libcap with libattr support Ben Boeckel
2015-10-24 21:39 ` [Buildroot] [PATCH 1/1] libcap: depend on host-attr for the host Ben Boeckel
2015-10-26  8:58   ` Thomas Petazzoni
2015-10-26 14:27     ` Ben Boeckel
2015-10-27  6:29       ` Thomas Petazzoni
2015-10-29  2:49         ` Ben Boeckel
2015-10-29  2:48 ` Ben Boeckel [this message]
2015-11-13  1:37   ` [Buildroot] [PATCH] makefile: remove LD_LIBRARY_PATH from the environment Ben Boeckel
2015-11-13  6:37   ` Arnout Vandecappelle
2015-11-13  9:00     ` Yann E. MORIN
2015-11-13 22:19       ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1446086895-28252-1-git-send-email-mathstuf@gmail.com \
    --to=mathstuf@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox