From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lada Trimasova Date: Wed, 23 Dec 2015 12:46:37 +0000 Subject: [Buildroot] [PATCH 2/2] Fixing xdriver_xf86-video-ati dependencies In-Reply-To: <20151222164501.GA21998@free.fr> References: <1450790990-28939-1-git-send-email-ltrimas@synopsys.com> <1450790990-28939-3-git-send-email-ltrimas@synopsys.com> <20151222164501.GA21998@free.fr> Message-ID: <1450874796.7878.10.camel@synopsys.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Right, xdriver_xf86-video-ati links with libdrm_radeon directly. I'll fix that and send an update. Regards, Lada Trimasova. On Tue, 2015-12-22 at 17:45 +0100, Yann E. MORIN wrote: Lada, All, On 2015-12-22 16:29 +0300, Lada Trimasova spake thusly: This package depends on the radeon driver from libdrm and depends on DRI support in xserver_xorg-server, to achieve this we select the Radeon mesa3d DRI driver. Fixes: http://autobuild.buildroot.net/results/9da/9da4ffdf1c4ec78ae37322e253cb769340116035 Signed-off-by: Lada Trimasova > Cc: Alexey Brodkin > Cc: Thomas Petazzoni > Cc: Peter Korsgaard > --- package/x11r7/xdriver_xf86-video-ati/Config.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/package/x11r7/xdriver_xf86-video-ati/Config.in b/package/x11r7/xdriver_xf86-video-ati/Config.in index 191c20f..ef96366 100644 --- a/package/x11r7/xdriver_xf86-video-ati/Config.in +++ b/package/x11r7/xdriver_xf86-video-ati/Config.in @@ -1,8 +1,8 @@ config BR2_PACKAGE_XDRIVER_XF86_VIDEO_ATI bool "xf86-video-ati" depends on BR2_PACKAGE_MESA3D - select BR2_PACKAGE_LIBDRM if BR2_PACKAGE_MESA3D_DRI_DRIVER_RADEON - select BR2_PACKAGE_LIBDRM_RADEON if BR2_PACKAGE_MESA3D_DRI_DRIVER_RADEON + select BR2_PACKAGE_LIBDRM + select BR2_PACKAGE_MESA3D_DRI_DRIVER_RADEON You ar eremoving the 'select' on BR2_PACKAGE_LIBDRM_RADEON. This is OK with the current code, because BR2_PACKAGE_MESA3D_DRI_DRIVER_RADEON does the 'select' too. However, does xdriver_xf86-video-ati link with libdrm_radeon directly? If so, and the build failure you linked to above seems to imply it does, then you should keep the 'select' here, because it is a direct dependency. Otherwise, I'm Ok with the change. Regards, Yann E. MORIN. select BR2_PACKAGE_XLIB_LIBXCOMPOSITE select BR2_PACKAGE_XPROTO_FONTSPROTO select BR2_PACKAGE_XPROTO_GLPROTO -- 2.5.0 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot