Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Romain Naour <romain.naour@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [RFC] package/gdb: simplify the disable doc hook
Date: Mon,  1 Feb 2016 15:22:27 +0100	[thread overview]
Message-ID: <1454336547-23655-1-git-send-email-romain.naour@gmail.com> (raw)

Depending on the gdb version we need to remove the documentation
build from different place in the gdb source tree.

From: gdb/Makefile.in
3aecfbd03dd2a8d49c97f1e68df42b077dbbd396

From: bfd/doc/Makefile.in and gprof/Makefile.in
1180bafd8e1de2b12db3c7c235b128c9e48d4abb

From: etc/Makefile.in
as proposed by [1]

The issue come from the commit e30465112ed4c6320dd19107302057a5f7712cf2
in the gdb tree that update the "missing" script which now return the
error code 127 when a tool is missing.

The same kind of hook will be needed when the binutils package will be
updated to 2.26 release.

Fixes:
http://autobuild.buildroot.net/results/55d/55d95d7decc8ff8c451601a38ce2c2818fe23bcc

[1] http://patchwork.ozlabs.org/patch/572150/

Signed-off-by: Romain Naour <romain.naour@gmail.com>
Cc: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 package/gdb/gdb.mk | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/package/gdb/gdb.mk b/package/gdb/gdb.mk
index 3b0f501..65b2e67 100644
--- a/package/gdb/gdb.mk
+++ b/package/gdb/gdb.mk
@@ -53,13 +53,8 @@ endif
 
 # Prevent gdb to build the documentation
 define GDB_DISABLE_DOC
-	$(SED) '/^SUBDIRS =/ s/doc//' $(@D)/gdb/Makefile.in
-	if test -e $(@D)/bfd/doc/Makefile.in ; then \
-		$(SED) 's/^INFO_DEPS =.*$$/INFO_DEPS =/' $(@D)/bfd/doc/Makefile.in ; \
-	fi
-	if test -e $(@D)/gprof/Makefile.in ; then \
-		$(SED) 's/^INFO_DEPS =.*$$/INFO_DEPS =/' $(@D)/gprof/Makefile.in ; \
-	fi
+	echo "#!/bin/sh" > $(@D)/missing
+	echo "exit 0" >> $(@D)/missing
 endef
 GDB_PRE_CONFIGURE_HOOKS += GDB_DISABLE_DOC
 HOST_GDB_PRE_CONFIGURE_HOOKS += GDB_DISABLE_DOC
-- 
2.4.3

             reply	other threads:[~2016-02-01 14:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-01 14:22 Romain Naour [this message]
2016-02-01 15:01 ` [Buildroot] [RFC] package/gdb: simplify the disable doc hook Thomas Petazzoni
2016-02-01 18:30   ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1454336547-23655-1-git-send-email-romain.naour@gmail.com \
    --to=romain.naour@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox