From: Kinsella, Ray <ray.kinsella@intel.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v5] package/radlib: new package
Date: Sun, 24 Apr 2016 14:49:18 +0000 [thread overview]
Message-ID: <1461509358.5247.3.camel@intel.com> (raw)
In-Reply-To: <20160420175900.2d55af03@free-electrons.com>
Thanks Thomas,
The backend 'choice' needs to be reworked to to remove sqllite. mysql
or postgresql is used in 'raddatabase', these are mutually exclusive.
SQLite ('radsqlite') is used seperately, it can be simply be enabled or
disabled depending on whether it is BR2_PACKAGE_SQLITE is enabled.
Thanks,
Ray K
On Wed, 2016-04-20 at 17:59 +0200, Thomas Petazzoni wrote:
> Hello,
>
> On Wed, 20 Apr 2016 15:44:14 +0000, Kinsella, Ray wrote:
>
> > Please ignore this patch, as the current radlib build results in an
> > incorrect dynamic link table in librad.
> >
> > Lines like the following are just broken
> >
> > raddebug_LDADD += -lmysqlclient
> > radmrouted_LDADD += -lmysqlclient
> >
> > or
> >
> > radmrouted_LDADD += $(MYSQL_LIBS)
> > raddebug_LDADD += $(MYSQL_LIBS)
> >
> > The radlib library (librad.so) should link against
> > mysql/sqlite/postgresql. The radlib executables (shown above)
> > should
> > then link again radlib (librad.so).
>
> There were some other issues in your patch, and I was planning to
> review it. I'll try to give you some feedback so that you can take it
> into account for your v6.
>
> Thanks,
>
> Thomas
prev parent reply other threads:[~2016-04-24 14:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-13 16:06 [Buildroot] [PATCH v5] package/radlib: new package ray.kinsella at intel.com
2016-04-13 16:06 ` ray.kinsella at intel.com
2016-04-21 23:02 ` Arnout Vandecappelle
2016-04-24 15:15 ` Kinsella, Ray
2016-05-02 20:44 ` Arnout Vandecappelle
2016-06-14 14:20 ` Kinsella, Ray
2016-04-20 15:44 ` Kinsella, Ray
2016-04-20 15:59 ` Thomas Petazzoni
2016-04-24 14:49 ` Kinsella, Ray [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1461509358.5247.3.camel@intel.com \
--to=ray.kinsella@intel.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox