From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?ISO-8859-1?Q?J=F6rg?= Krause <joerg.krause@embedded.rocks>
Date: Fri, 06 May 2016 08:26:58 +0200
Subject: [Buildroot] [PATCH 1/1] package/macchanger: fix musl build
In-Reply-To: <18bdd441-ce98-cdb6-b233-5c97b328ad9e@mind.be>
References: <1453588987-16758-1-git-send-email-bernd.kuhls@t-online.de>
 <1462218005.2955.1.camel@embedded.rocks>
 <18bdd441-ce98-cdb6-b233-5c97b328ad9e@mind.be>
Message-ID: <1462516018.2064.1.camel@embedded.rocks>
List-Id: <buildroot.busybox.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: buildroot@busybox.net

Dear Arnout,

On Mo, 2016-05-02 at 23:32 +0200, Arnout Vandecappelle wrote:
> On 05/02/16 21:40, J?rg Krause wrote:
> > Hi,
> > 
> > On Sa, 2016-01-23 at 23:43 +0100, Bernd Kuhls wrote:
> [snip]
> > > +@@ -113,7 +113,7 @@ mc_net_info_get_permanent_mac (const net
> > > +?	epa->size = IFHWADDRLEN;
> > > +
> > > +?	memcpy(&req, &(net->dev), sizeof(struct ifreq));
> > > +-	req.ifr_data = (caddr_t)epa;
> > > ++	req.ifr_data = (char *)epa;
> > > +
> > > +?	if (ioctl(net->sock, SIOCETHTOOL, &req) < 0) {
> > > +?		perror ("[ERROR] Could not read permanent
> > > MAC");
> > 
> > any reason why this patch is marked as "Changes Requested"? The
> > build
> > error is still present...
> 
> ? IIRC, Bernd posted almost a hundred patches at the time for musl
> fixes, most?
> of which were taken from Alpine Linux, and almost all of which had
> insufficient?
> explanation of the problem and of the fix (nothing more than "fix
> musl build"?
> and a reference to the alpine patch). Also many of them were simply
> incorrect:?
> they would maybe fix the build, but possibly introducing other bugs
> or sometimes?
> just breaking the code. So after reviewing and rejecting a dozen of
> them,?
> ThomasP just made a generic comment that all of them should be done
> more?
> carefully and marked all of them as Changes Requested.
> 
> ? If you would like to recover and review them, just select in
> patchwork patches?
> from Bernd that are marked as changes requested and that have musl in
> the?
> subject. Feel free to repost (with better commit messages of course).

I see! Yes, I will do this for some packages.

> ? This one specifically does look good to me - except for the commit
> message,?
> which should be something like:
> 
> caddr_t is a BSD type. POSIX usually uses void* instead, but
> specifically in?
> struct ifreq the type of ifr_data is char*.
> 

Many thanks!

Best regards
J?rg Krause