Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Geoff Levand <geoff@infradead.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 6/6] package/go: Set file timestamp
Date: Tue, 24 May 2016 14:35:40 -0700	[thread overview]
Message-ID: <1464125740.5014.53.camel@infradead.org> (raw)
In-Reply-To: <20160524211354.20788c35@free-electrons.com>

Hi,

On Tue, 2016-05-24 at 21:13 +0200, Thomas Petazzoni wrote:
> On Thu, 19 May 2016 22:25:02 +0000, Geoff Levand wrote:
> > Set all file timestamps to prevent the go compiler from rebuilding any
> > built in packages when programs are built.
>
> That's weird, why is it needed? 

If the times are not set, when a go program is built go may
rebuild some of the installed packages.  This is the same
kind of time based dependecy checking make does.

Without this change I can observe installed packages being
rebuilt when flannel is built on my machine.

> Why are timestamps wrong in the first
> place?

I guess go is built in parallel, and so the artifacts have
different times.  Gentoo does a similar timestamp operation
in the pkg_postinst of its ebuild:

 https://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/dev-lang/go/go-9999.ebuild?logsort=cvs&revision=1.30&view=markup

-Geoff

  parent reply	other threads:[~2016-05-24 21:35 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-19 22:25 [Buildroot] [PATCH v2 0/6] Fixes for go language support Geoff Levand
2016-05-19 22:25 ` [Buildroot] [PATCH v2 2/6] package/go: Add HOST_GO_TARGET_ENV Geoff Levand
2016-05-19 22:25 ` [Buildroot] [PATCH v2 5/6] package/flannel: Add BR2_TOOLCHAIN_HAS_THREADS Geoff Levand
2016-05-19 22:25 ` [Buildroot] [PATCH v2 3/6] package/flannel: Use HOST_GO_TARGET_ENV Geoff Levand
2016-05-19 22:25 ` [Buildroot] [PATCH v2 6/6] package/go: Set file timestamp Geoff Levand
2016-05-24 19:13   ` Thomas Petazzoni
2016-05-24 20:12     ` Christian Stewart
2016-05-24 21:35     ` Geoff Levand [this message]
2016-05-19 22:25 ` [Buildroot] [PATCH v2 4/6] package/go: Add HOST_GO_CGO_ENABLED Geoff Levand
2016-05-19 22:25 ` [Buildroot] [PATCH v2 1/6] package/go: Build host tools with host CC Geoff Levand
2016-05-24 19:11   ` Thomas Petazzoni
2016-05-24 21:31     ` Geoff Levand
2016-05-24 21:34   ` [Buildroot] [PATCH v2.1 " Geoff Levand
2016-05-25 14:05     ` Thomas Petazzoni
2016-05-25 16:41       ` Geoff Levand
2016-05-25 20:59         ` Thomas Petazzoni
2016-05-26 17:24           ` Geoff Levand
2016-05-26 17:30             ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1464125740.5014.53.camel@infradead.org \
    --to=geoff@infradead.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox