Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Carlos Santos <casantos@datacom.com.br>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] syslog-ng: depend on !BR2_STATIC_LIBS
Date: Sun, 13 Jan 2019 10:43:27 -0200 (BRST)	[thread overview]
Message-ID: <1466149302.1776233.1547383407186.JavaMail.zimbra@datacom.com.br> (raw)
In-Reply-To: <20190113084722.19441-1-judge.packham@gmail.com>

> From: "Chris Packham" <judge.packham@gmail.com>
> To: "buildroot" <buildroot@buildroot.org>
> Cc: "Carlos Santos" <casantos@datacom.com.br>, "Chris Packham" <judge.packham@gmail.com>
> Sent: Domingo, 13 de janeiro de 2019 6:47:22
> Subject: [PATCH v2] syslog-ng: depend on !BR2_STATIC_LIBS

> Upstream now unconditionally requires dlfcn.h:
> -
> https://github.com/balabit/syslog-ng/commit/01258e56abc5804f8ea977ff9ab98cc8e2fd4702
> 
> Fixes:
> -
> http://autobuild.buildroot.net/results/c0bca852e053cd0e021205b3a949e750ae602333
> 
> Signed-off-by: Chris Packham <judge.packham@gmail.com>
> ---
> Changes in v2:
> - update comment when toolchain prerequisites are not met (thanks Baruch)
> 
> package/syslog-ng/Config.in | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/package/syslog-ng/Config.in b/package/syslog-ng/Config.in
> index fbc236221a..6407645974 100644
> --- a/package/syslog-ng/Config.in
> +++ b/package/syslog-ng/Config.in
> @@ -3,6 +3,7 @@ config BR2_PACKAGE_SYSLOG_NG
> 	depends on BR2_USE_WCHAR # glib2
> 	depends on BR2_TOOLCHAIN_HAS_THREADS
> 	depends on BR2_USE_MMU # fork()
> +	depends on !BR2_STATIC_LIBS # dlfcn.h
> 	depends on BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
> 	select BR2_PACKAGE_EVENTLOG
> 	select BR2_PACKAGE_LIBGLIB2
> @@ -15,7 +16,8 @@ config BR2_PACKAGE_SYSLOG_NG
> 
> 	  https://syslog-ng.org/
> 
> -comment "syslog-ng needs a toolchain w/ wchar, threads"
> +comment "syslog-ng needs a toolchain w/ dynamic library, wchar, threads"
> 	depends on BR2_USE_MMU
> -	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
> +	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || \
> +		BR2_STATIC_LIBS
> 	depends on BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
> --
> 2.20.1

Reviewed-by: Carlos Santos <casantos@datacom.com.br>

-- 
Carlos Santos (Casantos) - DATACOM, P&D

  reply	other threads:[~2019-01-13 12:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-13  8:47 [Buildroot] [PATCH v2] syslog-ng: depend on !BR2_STATIC_LIBS Chris Packham
2019-01-13 12:43 ` Carlos Santos [this message]
2019-01-13 13:30 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1466149302.1776233.1547383407186.JavaMail.zimbra@datacom.com.br \
    --to=casantos@datacom.com.br \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox