From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v1 1/1] package/busybox: support spaces in module aliases in mdev
Date: Fri, 1 Jul 2016 21:56:19 +0300 [thread overview]
Message-ID: <1467399379-945-1-git-send-email-andriy.shevchenko@linux.intel.com> (raw)
The new change which enabled automatic module loading on boot does not handle
the cases when module alias includes spaces. It prevents modules to be loaded
since script fails:
% find /sys/ -name modalias | xargs sort -u
sort: /sys/devices/platform/Fixed: No such file or directory
First alias in question is "platform:Fixed MDIO bus".
Amend the script to support above like cases.
Fixes: 07f46c2b6dae ("package/busybox: support automatic module loading with mdev")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
package/busybox/S10mdev | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/package/busybox/S10mdev b/package/busybox/S10mdev
index 4cb31de..f72c43f 100644
--- a/package/busybox/S10mdev
+++ b/package/busybox/S10mdev
@@ -9,7 +9,9 @@ case "$1" in
echo /sbin/mdev >/proc/sys/kernel/hotplug
/sbin/mdev -s
# coldplug modules
- find /sys/ -name modalias | xargs sort -u | xargs modprobe -abq
+ find /sys -name modalias -print0 | xargs -0 sort -u | while read ma; do
+ modprobe -bq "$ma"
+ done
;;
stop)
;;
--
2.8.1
next reply other threads:[~2016-07-01 18:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-01 18:56 Andy Shevchenko [this message]
2016-07-01 20:54 ` [Buildroot] [PATCH v1 1/1] package/busybox: support spaces in module aliases in mdev Thomas Petazzoni
2016-07-01 21:53 ` Yann E. MORIN
2016-07-02 11:43 ` Andy Shevchenko
2016-07-02 11:16 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467399379-945-1-git-send-email-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox