From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vlad Zakharov Date: Wed, 24 Aug 2016 16:47:37 +0000 Subject: [Buildroot] [PATCH] stella: fix compiler search in configure script In-Reply-To: <87d1l7qn2y.fsf@dell.be.48ers.dk> References: <1470910831-18439-1-git-send-email-vzakhar@synopsys.com> <87d1l7qn2y.fsf@dell.be.48ers.dk> Message-ID: <1472057256.4369.25.camel@synopsys.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hi Peter, This patch was adopted in upstream Stella project: https://sourceforge.net/p/stella/code/3315/ and will come up in next Stella release. So it need to be reverted after update to upcoming Stella release. Thx. On Wed, 2016-08-17 at 20:15 +0200, Peter Korsgaard wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > "Vlad" == Vlad Zakharov writes: > ?> In configure script there are some tests that are looking for > ?> a suitable compiler. For this purpose script tries to compile > ?> and link some C++ code that is hardcoded in the body of script. > > ?> The problem is that only linker flags ($LDFLAGS) are passed to the > ?> compiler when the script is compiling test code. Therefore some > ?> necessary command line options can be lost and this would lead to > ?> errors. > > ?> This exactly happens to ARC: > ?>???1. -matomic option is lost as it compiler option, > ?>???2. test code compilation fails, > ?>???3. the script decides not to use arc-buildroot-linux-uclibc-g++, > ?>???4. scipt checks host compiler (x86_64-linux-gnu-g++ in your case), > ?>???5. package is being built for x86_64, not for ARC. > > ?> About last 2 steps - I don't know why configure script should try > ?> to build stella for host machine. As for me an error should be > ?> raised and a build should be stopped. But this is up to stella > ?> developers. > > ?> Current patch adds compiler options ($CPPLFAGS) when compiling > > You are actually passing CXXFLAGS. Committed with that fixed. > > Don't forget to submit the patch upstream! > -- Best regards, Vlad Zakharov