Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Cyril Bur <cyrilbur@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/kvm-unit-tests: new package
Date: Tue, 20 Sep 2016 09:12:25 +1000	[thread overview]
Message-ID: <1474326745.4451.3.camel@gmail.com> (raw)
In-Reply-To: <20160919164843.3896425f@free-electrons.com>

On Mon, 2016-09-19 at 16:48 +0200, Thomas Petazzoni wrote:
> Hello,
> 
> On Thu, 18 Aug 2016 09:02:36 +1000, Cyril Bur wrote:
> > 
> > The unit tests are tiny guest operating systems that generally
> > execute
> > only tens of lines of C and assembler test code in order to obtain
> > its
> > PASS/FAIL result. Unit tests provide KVM and virt hardware
> > functional
> > testing by targeting the features through minimal implementations
> > of
> > their use per the hardware specification. The simplicity of unit
> > tests
> > make them easy to verify they are correct, easy to maintain, and
> > easy
> > to use in timing measurements. Unit tests are also often used for
> > quick and dirty bug reproducers. The reproducers may then be kept
> > as
> > regression tests. It's strongly encouraged that patches
> > implementing
> > new KVM features are submitted with accompanying unit tests.
> > http://www.linux-kvm.org/page/KVM-unit-tests
> > 
> > Signed-off-by: Cyril Bur <cyrilbur@gmail.com>
> > ---
> > ?package/Config.in????????????????????????|??1 +
> > ?package/kvm-unit-tests/Config.in?????????| 17 ++++++++++++
> > ?package/kvm-unit-tests/kvm-unit-tests.mk | 45
> > ++++++++++++++++++++++++++++++++
> > ?3 files changed, 63 insertions(+)
> > ?create mode 100644 package/kvm-unit-tests/Config.in
> > ?create mode 100644 package/kvm-unit-tests/kvm-unit-tests.mk
> 
> Applied to master with the following changes:
> 
> ????[Thomas:
> ?????- order architecture dependencies in Config.in alphabetically.
> ?????- rewrap Config.in help text, lines were too long
> ?????- add an empty line between the package description and the
> upstream
> ???????project URL in the Config.in help text
> ?????- don't make KVM_UNIT_TESTS_ARCH default to $(ARCH). This was
> not
> ???????correct for i386 for example. Instead, just handle the few
> ???????architectures that the package supports.
> ?????- remove useless double quotes in variable definitions.
> ?????- remove --prefix="$(TARGET_DIR)" from CONF_OPTS. It was
> installing
> ???????everything in /share/ and not /usr/share/, and setting the
> prefix to
> ???????TARGET_DIR at configure time is not good. Instead, pass
> DESTDIR at
> ???????installation time.]
> 

Thanks for the fixups.

Cyril

> Thomas

  parent reply	other threads:[~2016-09-19 23:12 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-17 23:02 [Buildroot] [PATCH] package/kvm-unit-tests: new package Cyril Bur
2016-09-19 14:48 ` Thomas Petazzoni
2016-09-19 21:07   ` Peter Korsgaard
2016-09-19 23:12   ` Cyril Bur [this message]
2016-09-21  7:24 ` Thomas Petazzoni
2016-09-22  0:01   ` Cyril Bur
2016-09-22  5:18     ` Peter Korsgaard
2016-09-22  9:34       ` Thomas Petazzoni
2016-09-22  9:42         ` Peter Korsgaard
2016-09-23  6:06       ` Cyril Bur
2016-09-23  6:12         ` Thomas Petazzoni
2016-09-23  6:14           ` Cyril Bur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1474326745.4451.3.camel@gmail.com \
    --to=cyrilbur@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox