Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Jérôme Pouiller" <jezz@sysmic.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] Canonicalize $(BASE_DIR)
Date: Fri, 30 Sep 2016 12:09:54 +0200	[thread overview]
Message-ID: <1475230194-18524-3-git-send-email-jezz@sysmic.org> (raw)
In-Reply-To: <1475230194-18524-1-git-send-email-jezz@sysmic.org>

If compilation path contains symlinks, $(*_DIR) variables does not contains
same values depending if user run 'make O=out' or 'make -C out'.

This patch always canonicalize $(BASE_DIR) to avoid this problem.

Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index 5e4daef..5c907e5 100644
--- a/Makefile
+++ b/Makefile
@@ -136,7 +136,7 @@ endif
 # line doesn't affect the environment of $(shell ..) calls, so
 # explictly throw away any output from 'cd' here.
 export CDPATH :=
-BASE_DIR := $(shell mkdir -p $(O) && cd $(O) >/dev/null && pwd)
+BASE_DIR := $(shell mkdir -p $(O) && cd $(O) >/dev/null && readlink -m .)
 $(if $(BASE_DIR),, $(error output directory "$(O)" does not exist))
 
 
-- 
1.9.1

  parent reply	other threads:[~2016-09-30 10:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-30 10:09 [Buildroot] [PATCH 0/2] Symlinks in compilation path confuse check-host-rpath Jérôme Pouiller
2016-09-30 10:09 ` [Buildroot] [PATCH 1/2] check-host-rpath: support symlinks in rpath Jérôme Pouiller
2016-10-04 21:33   ` Arnout Vandecappelle
2016-10-05  8:54     ` Jérôme Pouiller
2016-10-16 10:58       ` Arnout Vandecappelle
2016-10-16 11:43         ` Samuel Martin
2016-09-30 10:09 ` Jérôme Pouiller [this message]
2016-10-03 21:21 ` [Buildroot] [PATCH 0/2] Symlinks in compilation path confuse check-host-rpath Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1475230194-18524-3-git-send-email-jezz@sysmic.org \
    --to=jezz@sysmic.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox