Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Jörg Krause" <joerg.krause@embedded.rocks>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] package/upmpdcli: add patch to fix error not detecting jsoncpp
Date: Tue, 11 Oct 2016 21:38:39 +0200	[thread overview]
Message-ID: <1476214719.1889.1.camel@embedded.rocks> (raw)
In-Reply-To: <8760oysmv5.fsf@dell.be.48ers.dk>

On Di, 2016-10-11 at 21:32 +0200, Peter Korsgaard wrote:
> > 
> > > 
> > > > 
> > > > > 
> > > > > > 
> > > > > > "J?rg" == J?rg Krause <joerg.krause@embedded.rocks> writes:
> 
> ?> Fixes:
> ?> http://autobuild.buildroot.net/results/205463c9ea8651911972c2835e2
> 8ded1912c811a
> ?> http://autobuild.buildroot.net/results/5e9279ee60c11a3dacacf6d78f8
> 7f8d1b92968f5
> ?> http://autobuild.buildroot.net/results/97043f8defd5a59ae39b4c7f095
> a10d15c7fe632
> ?> http://autobuild.buildroot.net/results/e775126d5939093289b1a833dd6
> 323ac293322ed
> ?> .. and many more.
> 
> ?> libmpdclient, libmicrohttpd and jsoncpp provide a .pc file. Use
> ?> pkg-config for detecting the libraries and for providing the
> necessary
> ?> details for compiling and linking.
> 
> ?> The current build system of upmpdcli does not use
> PKG_CHECK_MODULES, but
> ?> AC_LINK_IFELSE to detect jsoncpp. After bumping jsoncpp version
> from
> ?> 1.7.2 to 1.7.5 the detection fails, because the test program does
> not
> ?> compile anymore:
> 
> ?> """
> ?> In file included from
> ?> /usr/arm-buildroot-linux-
> gnueabi/sysroot/usr/include/json/autolink.h:9:0,
> ?>??????????????????from
> ?> /usr/arm-buildroot-linux-
> gnueabi/sysroot/usr/include/json/json.h:9,
> ?>??????????????????from test.c:1:
> ?> /usr/arm-buildroot-linux-
> gnueabi/sysroot/usr/include/json/config.h:155:9:
> ?> error: 'int64_t' does not name a type
> ?>??typedef int64_t Int64;
> 
> While changing to pkg-config is perfectly fine (if upstream accepts
> it),
> this problem is really about jsoncpp's config.h using int64_t without
> including <stdint.h>

Gladly, upmpdcli accepted to use pkg-config and jsoncpp fixed this
issue in [1].

[1]?https://github.com/open-source-parsers/jsoncpp/commit/ab0f1e234aa40
147e39cdfd0b97bf6527b8ea5e8

Best regards
J?rg Krause

  reply	other threads:[~2016-10-11 19:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-25 14:11 [Buildroot] [PATCH v2] package/upmpdcli: add patch to fix error not detecting jsoncpp Jörg Krause
2016-10-09 12:33 ` Thomas Petazzoni
2016-10-11 19:32 ` Peter Korsgaard
2016-10-11 19:38   ` Jörg Krause [this message]
2016-10-11 19:53     ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1476214719.1889.1.camel@embedded.rocks \
    --to=joerg.krause@embedded.rocks \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox