Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Jörg Krause" <joerg.krause@embedded.rocks>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] ubifs: Fix regression in ubifs_readdir()
Date: Wed, 02 Nov 2016 20:56:59 +0100	[thread overview]
Message-ID: <1478116619.8549.1.camel@embedded.rocks> (raw)
In-Reply-To: <20161101232215.5bf7cabd@free-electrons.com>

On Tue, 2016-11-01 at 23:22 +0100, Thomas Petazzoni wrote:
> Hello J?rg,
> 
> [E-mail thread hijacked from the linux-mtd mailing list, since there
> is
> a Buildroot related problem reported.]
> 
> On Sat, 29 Oct 2016 00:23:15 +0200, J?rg Krause wrote:
> 
> > > > I'm not sure if it's related to the issue reported by Peter
> > > > Rosin
> > > > and
> > > > Ralph Sennhauser, but I am still getting a kernel panic using
> > > > UBIFS
> > > > with OverlayFS on Linux v4.9.0-rc2 with this patch applied:??
> > > 
> > > Does reverting c83ed4c9dbb35 help?
> > > And are you 100% sure you applied the fix???
> > 
> > I double double checked. The fix was applied on the git tree, but
> > the
> > compiler cache (I am using Buildroot with this option enabled)
> > fooled
> > me by using an old copy. After disabling the compiler cache I got a
> > fixed build of the kernel. The panic is gone! Thanks!
> 
> This is *really* bad. Which Buildroot version are you using?

2016.11 #

Note that I am using Buildroot as a submodule [1] and I needed to port
the br2-external tree. Maybe I messed something up?

> Are you able to reproduce the bad ccache behavior here?

Yes, I am. Linux kernel source directory is located locally and the
path is set using LINUX_OVERRIDE_SRCDIR in local.mk.

1/ Checkout Linux kernel version 4.7.10
2/ make linux-dirclean all
3/ Booted Linux version is 4.7.10

4/ Checkout Linux kernel version 4.8.5
5/ make linux-dirclean all
6/ Booted Linux version is still 4.7.10

> A modified source code should definitely lead to a different hash of
> the preprocessed code, and therefore there shouldn't be such a
> confusion between two cache results.

I checked the Linux source files in output/build/linux-custom/ and they
are correct - after step 2 the directory contains the Linux sources of
version 4.7.10 and after step 5 it contains version 4.8.5.

[1] https://github.com/Openwide-Ingenierie/buildroot-submodule

Best regards,
J?rg Krause

  reply	other threads:[~2016-11-02 19:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1477648432-9543-1-git-send-email-richard@nod.at>
     [not found] ` <1477671544.8927.1.camel@embedded.rocks>
     [not found]   ` <c542e099-0404-be8e-ebeb-d4265d3204d6@nod.at>
     [not found]     ` <1477693395.31471.1.camel@embedded.rocks>
2016-11-01 22:22       ` [Buildroot] [PATCH] ubifs: Fix regression in ubifs_readdir() Thomas Petazzoni
2016-11-02 19:56         ` Jörg Krause [this message]
2016-11-02 20:49           ` Thomas Petazzoni
2016-11-02 22:49             ` Jörg Krause
2016-11-03  2:46               ` Arnout Vandecappelle
2016-11-03  7:23                 ` Jörg Krause
2016-11-03 10:22                   ` Arnout Vandecappelle
2016-11-07 22:08                     ` Jörg Krause
2016-11-07 22:24                       ` Jörg Krause
2016-11-07 22:54                     ` Jörg Krause

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1478116619.8549.1.camel@embedded.rocks \
    --to=joerg.krause@embedded.rocks \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox