From: "Jörg Krause" <joerg.krause@embedded.rocks>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/tremor: fix build with Thumb only ARM archs
Date: Tue, 15 Nov 2016 23:09:09 +0100 [thread overview]
Message-ID: <1479247749.25678.1.camel@embedded.rocks> (raw)
In-Reply-To: <83e53e9a-4cc5-f02e-53c6-499c68ffa259@mind.be>
On Tue, 2016-11-15 at 22:18 +0100, Arnout Vandecappelle wrote:
>
> On 15-11-16 21:46, J?rg Krause wrote:
> > Some ARM architectures like ARNv7-M only supports Thumb
> > instructions,
> > but the tremor build configuration enables ARM assembly code
> > unconditionally for all arm triplets by defining _ARM_ASSEM_.
> >
> > We are overriding this by undefining this macro for ARM
> > architectures
> > not supporting ARM instructions.
> >
> > Fixes:
> > http://autobuild.buildroot.net/results/054/054f1c77b0e5d46b2dc53769
> > 469c0ed03e6b79ef/
> > http://autobuild.buildroot.net/results/ba1/ba1760b1428584f70e44dbff
> > b8218ff3ee55e702/
> > http://autobuild.buildroot.net/results/2a6/2a687853cf0bc832fef29f88
> > de0d85bd495fe87d/
> > http://autobuild.buildroot.net/results/cb6/cb6c560bf31834aadbe3d13a
> > 118b31ea8190159b/
> >
> > Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>
>
> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Many thanks for the review!
> ?However, just to be sure, could you do a test with a toolchain for a
> cpu that
> does have ARM instructions, but is configured with
> BR2_ARM_INSTRUCTIONS_THUMB?
Tested successfully with BR2_cortex_a9 and BR2_ARM_CPU_HAS_THUMB2.
Best regards,
J?rg Krause
next prev parent reply other threads:[~2016-11-15 22:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-15 20:46 [Buildroot] [PATCH] package/tremor: fix build with Thumb only ARM archs Jörg Krause
2016-11-15 21:18 ` Arnout Vandecappelle
2016-11-15 22:09 ` Jörg Krause [this message]
2016-11-15 22:31 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1479247749.25678.1.camel@embedded.rocks \
--to=joerg.krause@embedded.rocks \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox