Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Kellermann <christian.kellermann@solectrix.de>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] linux: Setting a repo_version is mandatory for custom repositories
Date: Mon, 12 Dec 2016 12:27:36 +0100	[thread overview]
Message-ID: <1481542057-19945-1-git-send-email-christian.kellermann@solectrix.de> (raw)
In-Reply-To: <58df8b4b-2d61-b93d-c96b-69ac9a4c084c@mind.be>



>   Unless I'm very mistaken, this will never trigger, because the
>  option will be "" instead of empty when it has not been set by the
>  user. So it should be qstrip'ped.

I have added the qstrip and also added the warning for the linux-header package.

>   I think it is more convenient to check $(LINUX_VERSION).

I don't understand what you mean by this.

>   You can also drop the outer condition, so that it also checked for
>  BR2_LINUX_KERNEL_CUSTOM_VERSION. But then of course it should still
>  be in an ifeq ($(BR2_LINUX_KERNEL),y) condition. And you should
>  check if the CUSTOM_LOCAL and OVERRIDE_SRCDIR options still work
>  correctly.

I don't think this will be easier to read though. But if you think
it's an improvement I will change the patches accordingly.

CUSTOM_LOCAL works for me, how do I test OVERRIDE_SRCDIR?

>   And while you're at it, perhaps you can do the same for LINUX_SITE.

Did this.

Thanks,

Christian

  reply	other threads:[~2016-12-12 11:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-06  8:13 [Buildroot] [PATCH 1/1] linux: Setting a repo_version is mandatory for custom repositories Christian Kellermann
2016-12-06 23:26 ` Arnout Vandecappelle
2016-12-12 11:27   ` Christian Kellermann [this message]
2016-12-12 11:27     ` [Buildroot] [PATCH] " Christian Kellermann
2016-12-17 14:58       ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1481542057-19945-1-git-send-email-christian.kellermann@solectrix.de \
    --to=christian.kellermann@solectrix.de \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox