From: "Jörg Krause" <joerg.krause@embedded.rocks>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] package/mpd: fix static linking with tremor
Date: Wed, 11 Jan 2017 20:56:27 +0100 [thread overview]
Message-ID: <1484164587.2499.1.camel@embedded.rocks> (raw)
In-Reply-To: <8760llkbqg.fsf@dell.be.48ers.dk>
On Wed, 2017-01-11 at 13:44 +0100, Peter Korsgaard wrote:
> > > > > > "J?rg" == J?rg Krause <joerg.krause@embedded.rocks> writes:
>
> ?> Although tremor (the library is named vorbisidec) provides a pkg-
> config
> ?> file, mpd does not use it to find tremor. Since version 0.20 does
> throw
> ?> an error instead of a warning, that's why the issue was left
> unnoticed
> ?> by the autobuilders.
>
> ?> Help mpd to find tremor by providing the path to the library and
> passing
> ?> LIBS through the environment. We use the host pkg-config tool to
> get the
> ?> correct values from the vorbisidec.pc file.
>
> ?> Fixes:
> ?> http://autobuild.buildroot.net/results/6b9/6b97403e70caa12c32494b1
> c82ce61d3e4e456f6/
>
> ?> Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>
> ?> ---
> ?> Changes v2:
> ?>???- Add autobuild link
>
> It seems like this isn't sufficient:
>
> http://autobuild.buildroot.net/results/2e3/2e3dbcdea34053675a0139c191
> 1b6da1a6670e2c/build-end.log
>
> Perhaps we need to add libogg to the pkg-config line as well?
This is not a static linking issue. My read is that mpd forgets to
consider OGG_LIBS in XIPH_LIBS. I will contact upstream about this
issue.
J?rg
prev parent reply other threads:[~2017-01-11 19:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-10 22:39 [Buildroot] [PATCH v2] package/mpd: fix static linking with tremor Jörg Krause
2017-01-11 11:31 ` Peter Korsgaard
2017-01-11 12:44 ` Peter Korsgaard
2017-01-11 19:56 ` Jörg Krause [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1484164587.2499.1.camel@embedded.rocks \
--to=joerg.krause@embedded.rocks \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox