From: Rahul Bedarkar <rahulbedarkar89@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] tinyxml2: fix build in static libs configuration
Date: Thu, 4 May 2017 00:34:14 +0530 [thread overview]
Message-ID: <1493838254-3658-1-git-send-email-rahulbedarkar89@gmail.com> (raw)
tinyxml2 can build both static and shared libraries. By default, only
shared library is built. Shared/static builds are controlled using
separate cmake flags BUILD_SHARED_LIBS and BUILD_STATIC_LIBS.
In static libs configuration, we internally pass -DBUILD_SHARED_LIBS=OFF
cmake flag to build system which disables both shared and static builds
of library, resulting in failures while linking executable with library.
So pass -DBUILD_STATIC_LIBS=ON cmake flag in case of static libs
configuration.
fixes:
http://autobuild.buildroot.net/results/d30/d301bcbe5db26068b35eaa94bd816ae8cf8ef2e1
Signed-off-by: Rahul Bedarkar <rahulbedarkar89@gmail.com>
---
package/tinyxml2/tinyxml2.mk | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/package/tinyxml2/tinyxml2.mk b/package/tinyxml2/tinyxml2.mk
index bb1e167..e289ca9 100644
--- a/package/tinyxml2/tinyxml2.mk
+++ b/package/tinyxml2/tinyxml2.mk
@@ -10,4 +10,8 @@ TINYXML2_LICENSE = Zlib
TINYXML2_LICENSE_FILES = readme.md
TINYXML2_INSTALL_STAGING = YES
+ifeq ($(BR2_STATIC_LIBS),y)
+TINYXML2_CONF_OPTS += -DBUILD_STATIC_LIBS=ON
+endif
+
$(eval $(cmake-package))
--
2.7.4
next reply other threads:[~2017-05-03 19:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-03 19:04 Rahul Bedarkar [this message]
2017-05-04 15:09 ` [Buildroot] [PATCH] tinyxml2: fix build in static libs configuration Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493838254-3658-1-git-send-email-rahulbedarkar89@gmail.com \
--to=rahulbedarkar89@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox