From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v1] busybox: Fix rtcwake to use /dev/rtc0 properly
Date: Fri, 24 Nov 2017 15:27:33 +0200 [thread overview]
Message-ID: <1511530053.25007.435.camel@linux.intel.com> (raw)
In-Reply-To: <b2f0d3bf-b8a1-c948-2013-35dc605c2cbd@mind.be>
On Thu, 2017-11-23 at 23:46 +0100, Arnout Vandecappelle wrote:
> Hi Andy,
>
> On 23-11-17 19:39, Andy Shevchenko wrote:
> > rtcwake from busybox has failed in case the /dev/rtc is a symlink
> > (which is default case for udev enabled systems) due to wrong
> > pathname
> > used for a sysfs wakeup attribute.
>
> In Buildroot, we don't accept "feature patches" for packages.
To be honest it's not a feature patch at all. It fixes (okay,
workarounds) obvious bug in rtcwake logic. Easy to reproduce. 100%
reproducible.
> We try to limit
> to patches that fix the build or complete breakage, sometimes also to
> make it
> work together with other packages. I think this patch doesn't fall in
> that category.
Whatever, your choice at the end.
>
> For sure, you should first send the patch upstream.
Are you sure I didn't?
The policy of Busybox mailing list is to reject (I'm not subscriber and
after a such policy would not like to be one). Happy contribution!
> Particularly in the case of
> busybox, Denys often proposes improved patches. If it gets accepted
> upstream,
> then we can consider including it in Buildroot as well.
Good luck!
I'm done with it. If Denys is caring about project he will take the
series (there are more patches than just one) from his private mailbox
(Cc was there as well).
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2017-11-24 13:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-23 18:39 [Buildroot] [PATCH v1] busybox: Fix rtcwake to use /dev/rtc0 properly Andy Shevchenko
2017-11-23 22:46 ` Arnout Vandecappelle
2017-11-24 13:27 ` Andy Shevchenko [this message]
2017-11-25 17:40 ` Arnout Vandecappelle
2017-11-27 11:20 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1511530053.25007.435.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox