Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Trent Piepho <tpiepho@impinj.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/8] pkg-waf.mk: check host-python version
Date: Tue, 2 Jan 2018 22:27:54 +0000	[thread overview]
Message-ID: <1514932073.26695.192.camel@impinj.com> (raw)
In-Reply-To: <20180102152807.31470-5-aduskett@gmail.com>

On Tue, 2018-01-02 at 10:28 -0500, Adam Duskett wrote:
>  
> +# We need a host-python to run waf
> +ifeq ($(BR2_PACKAGE_HOST_PYTHON3),y)
> +$(2)_DEPENDENCIES += host-python3
> +$(2)_WAF_PYTHON_PATH ?= $$(HOST_DIR)/bin/python3
> +else
> +$(2)_DEPENDENCIES += host-python
> +$(2)_WAF_PYTHON_PATH ?= $$(HOST_DIR)/bin/python2
> +endif

PYTHON_PATH above is called PYLIBVER in the five existing definitions
of this variable.   PYTHON_PATH already exists, and it the absolute
path in the target dir of sysconfigdata.

So it would be a lot more consistent to name this PYLIBVER.

It also seems like this variable will be re-created in a lot of
packages, if every package that needs to correctly call the host python
must define it.  I wonder if there could be an easier way for python
package files to call the host python correctly.  Like:

$(HOST_PYTHON_EXE)  Program to run for host python, 2 or 3 as selected.
$(HOST_PYTHON2_EXE) If you must have python 2
$(HOST_PYTHON3_EXE) If you must have python 3

  reply	other threads:[~2018-01-02 22:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-02 15:27 [Buildroot] [PATCH 0/8] python: clean up host version logic Adam Duskett
2018-01-02 15:28 ` [Buildroot] [PATCH 1/8] python: add selectable host entry Adam Duskett
2018-01-02 15:28 ` [Buildroot] [PATCH 2/8] python3: " Adam Duskett
2018-01-02 15:28 ` [Buildroot] [PATCH 3/8] python-setuptools: check host-python version Adam Duskett
2018-01-02 15:28 ` [Buildroot] [PATCH 4/8] pkg-waf.mk: " Adam Duskett
2018-01-02 22:27   ` Trent Piepho [this message]
2018-01-02 15:28 ` [Buildroot] [PATCH 5/8] ninja: " Adam Duskett
2018-01-02 15:28 ` [Buildroot] [PATCH 6/8] libselinux: " Adam Duskett
2018-01-02 15:28 ` [Buildroot] [PATCH 7/8] setools: " Adam Duskett
2018-01-02 15:28 ` [Buildroot] [PATCH 8/8] libselinux: " Adam Duskett
  -- strict thread matches above, loose matches on Subject: below --
2018-01-02 16:33 [Buildroot] [PATCH 0/8] python: clean up host version logic Adam Duskett
2018-01-02 16:33 ` [Buildroot] [PATCH 4/8] pkg-waf.mk: check host-python version Adam Duskett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1514932073.26695.192.camel@impinj.com \
    --to=tpiepho@impinj.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox