Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Trent Piepho <tpiepho@impinj.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] bluez5_utils: Make systemd link correctly
Date: Tue, 27 Feb 2018 21:56:44 +0000	[thread overview]
Message-ID: <1519768604.25567.207.camel@impinj.com> (raw)
In-Reply-To: <20180227213134.GD11186@scaer>

On Tue, 2018-02-27 at 22:31 +0100, Yann E. MORIN wrote:
> On 2018-02-27 13:21 -0800, Trent Piepho spake thusly:
> > The link in /etc/systemd/system/, named dbus-org.bluez.service, pointing to
> > ../../../../usr/lib/systemd/system/bluetooth.service has one too many ".." in
> > it.  Likely the target was copied from the other link in
> > /etc/systemd/system/bluetooth.target.wants/, which is one level deeper.
> > 
> > Adjust link to be correct.
> > 
> > Signed-off-by: Trent Piepho <tpiepho@impinj.com>
> 
> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> 
> However, this should not have any real problem on the target: this
> succession of '..' will eventually reach / which has its own '..'
> pointing back to itself; that is /.. points to / and so everything
> should just work as expected. Only on the build machine does that have
> an impact.
> 
> So, can you confirm that this is not fixing any runtime issue, but just
> making the symlink "less incorrect"?

Yes, it works on the target fs as the link bottoms out at /.  It just
breaks on the build machine to look at the file or if one runs a script
looking for broken symlinks after discovering all the *.wants links are
broken...

  reply	other threads:[~2018-02-27 21:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-27 21:21 [Buildroot] [PATCH] bluez5_utils: Make systemd link correctly Trent Piepho
2018-02-27 21:31 ` Yann E. MORIN
2018-02-27 21:56   ` Trent Piepho [this message]
2018-02-27 21:44 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1519768604.25567.207.camel@impinj.com \
    --to=tpiepho@impinj.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox