Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Trent Piepho <tpiepho@impinj.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] uboot: ensure host includes are searched before system default includes
Date: Fri, 2 Mar 2018 00:11:59 +0000	[thread overview]
Message-ID: <1519949518.25567.274.camel@impinj.com> (raw)
In-Reply-To: <20180301205429.4191-1-peter@korsgaard.com>

On Thu, 2018-03-01 at 21:54 +0100, Peter Korsgaard wrote:
> Commit baae5156ce37e (uboot: use local fdt headers) changed the uboot logic
> to pass the host include directories with -idirafter instead of -I, so
> include files local to u-boot would be preferred over host includes.
> 
> This unfortunately breaks configurations using
> BR2_TARGET_UBOOT_NEEDS_OPENSSL on hosts with incompatible openssl headers
> installed in the system default include directories as explained here:
> 
> http://lists.busybox.net/pipermail/buildroot/2018-March/214651.html
> 
> The problem is that -idirafter directories gets added to the very end of the
> search order, AFTER the system default directories.
> 
> Instead use -isystem which causes the directories to be added after -I but
> before the system default directories.  With this in place, the include
> directories of u-boot will first be scanned, followed by the host includes
> and finally the system default include directories.
> 
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>

Acked-by: Trent Piepho <tpiepho@impinj.com>

      parent reply	other threads:[~2018-03-02  0:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-01 20:54 [Buildroot] [PATCH] uboot: ensure host includes are searched before system default includes Peter Korsgaard
2018-03-01 23:12 ` Peter Korsgaard
2018-03-02  0:11 ` Trent Piepho [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1519949518.25567.274.camel@impinj.com \
    --to=tpiepho@impinj.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox