From: Angelo Compagnucci <angelo@amarulasolutions.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] support/download/file: fix file:// protocol handling
Date: Tue, 8 May 2018 15:28:31 +0200 [thread overview]
Message-ID: <1525786111-6206-1-git-send-email-angelo@amarulasolutions.com> (raw)
When a file is used a source for download using the file:// protocol, a
malformed url is passed to the file download script which then crashes.
Following an example of a wrong path passed to the script:
eval cp -v ''\''file:///home/angelo/DEV/TOOLCHAINSarmv7-eabihf--glibc--bleeding-edge-2017.11-1.tar.bz2'\''' ''\''/home/angelo/DEV/BUILDROOT/br_qemu_arm/build/.armv7-eabihf--glibc--bleeding-edge-2017.11-1.tar.bz2.f403PT/output'\'''.
Path passed to cp lacks of a / between dir and file part of the url,
moreover it presents a wrong file:// prefix.
Fixes:
cp: cannot stat
'file:///home/angelo/DEV/TOOLCHAINSarmv7-eabihf--glibc--bleeding-edge-2017.11-1.tar.bz2':
No such file or directory
Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
---
support/download/file | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/support/download/file b/support/download/file
index fefd6d2..6dd37b0 100755
--- a/support/download/file
+++ b/support/download/file
@@ -40,4 +40,4 @@ _localfiles() {
eval ${LOCALFILES} "${@}"
}
-_localfiles ${verbose} "'${dir}${file}'" "'${output}'"
+_localfiles ${verbose} "'${dir##file://}/${file}'" "'${output}'"
--
2.7.4
next reply other threads:[~2018-05-08 13:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-08 13:28 Angelo Compagnucci [this message]
2018-05-08 13:34 ` [Buildroot] [PATCH v2] support/download/file: fix file:// protocol handling Yann E. MORIN
2018-05-08 13:40 ` Angelo Compagnucci
2018-05-13 20:26 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1525786111-6206-1-git-send-email-angelo@amarulasolutions.com \
--to=angelo@amarulasolutions.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox