Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Carlos Santos <casantos@datacom.ind.br>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/5] gtest: Upgrade to GitHub HEAD
Date: Wed, 17 Feb 2016 16:17:12 -0200 (BRST)	[thread overview]
Message-ID: <1531197965.3282303.1455733032855.JavaMail.zimbra@datacom.ind.br> (raw)
In-Reply-To: <1629967145.779413.1445282966636.JavaMail.zimbra@datacom.ind.br>

> From: "Carlos Santos" <casantos@datacom.ind.br>
> To: "Alan Ott" <alan@softiron.co.uk>
> Cc: "Thomas Petazzoni" <thomas.petazzoni@free-electrons.com>, buildroot at buildroot.org
> Sent: Monday, October 19, 2015 5:29:26 PM
> Subject: Re: [Buildroot] [PATCH 4/5] gtest: Upgrade to GitHub HEAD

> Hello, Thomas and Alan,
> 
>> From: "Alan Ott" <alan@softiron.co.uk>
>> To: "Thomas Petazzoni" <thomas.petazzoni@free-electrons.com>
>> Cc: buildroot at buildroot.org
>> Sent: Wednesday, October 14, 2015 7:00:44 PM
>> Subject: Re: [Buildroot] [PATCH 4/5] gtest: Upgrade to GitHub HEAD
> 
>> On 10/14/2015 05:55 PM, Thomas Petazzoni wrote:
>>> On Wed, 14 Oct 2015 17:51:22 -0400, Alan Ott wrote:
>>>
>>>> +# The above revision must remain the same as the gmock package
>>>> +GTEST_SITE = $(call github,google,googletest,$(GTEST_VERSION))
>>>>   GTEST_INSTALL_STAGING = YES
>>>>   GTEST_INSTALL_TARGET = NO
>>>>   GTEST_LICENSE = BSD-3c
>>>>   GTEST_LICENSE_FILES = LICENSE
>>>> +GTEST_SUBDIR = googletest
>>> So gtest and gmock are in fact now part of the same repository/upstream
>>> project ? If that's the case, then I think we should simply get rid of
>>> the gtest and gmock packages, and have a single package named
>>> "googletest".
> 
> What about applying the submitted patches now, to fix the repository, and a
> different patch later to create the "googletest" package?
> 
>> Yes, that would probably be better. gmock depends on gtest, and gtest
>> can be standalone. Maybe we have one package with a submenu option to
>> build each target (and a dependency so gmock selects gtest).
>> 
>> Is that ok by you?
>> 
>> Alan.
> 
> Do you need any help to do this?

Hello Alan,

I noticed that this patch set is still in "Changes Requested" state. Is there anything I can do to help?

Carlos Santos (Casantos)
DATACOM, P&D

  reply	other threads:[~2016-02-17 18:17 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-14 21:51 [Buildroot] [PATCH 0/5] Move download links away from Google Code Alan Ott
2015-10-14 21:51 ` [Buildroot] [PATCH 1/5] dsp-tools: Move download link " Alan Ott
2015-10-14 21:51 ` [Buildroot] [PATCH 2/5] gst-dsp: " Alan Ott
2015-10-14 21:51 ` [Buildroot] [PATCH 3/5] gst-omapfb: " Alan Ott
2015-10-14 21:51 ` [Buildroot] [PATCH 4/5] gtest: Upgrade to GitHub HEAD Alan Ott
2015-10-14 21:55   ` Thomas Petazzoni
2015-10-14 22:00     ` Alan Ott
2015-10-15  7:10       ` Thomas Petazzoni
2015-10-19 19:29       ` Carlos Santos
2016-02-17 18:17         ` Carlos Santos [this message]
2016-02-17 20:50           ` Thomas Petazzoni
2016-02-18  0:13             ` Alan Ott
2016-02-18 16:14               ` Carlos Santos
2016-02-18 16:18                 ` Thomas Petazzoni
2016-02-18 19:26                   ` Carlos Santos
2015-10-14 21:51 ` [Buildroot] [PATCH 5/5] gmock: " Alan Ott
2015-10-14 21:56 ` [Buildroot] [PATCH 0/5] Move download links away from Google Code Thomas Petazzoni
2015-10-14 22:02   ` Alan Ott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1531197965.3282303.1455733032855.JavaMail.zimbra@datacom.ind.br \
    --to=casantos@datacom.ind.br \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox