From: Trent Piepho <tpiepho@impinj.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/1] qemu: add support for python3
Date: Mon, 10 Sep 2018 18:35:21 +0000 [thread overview]
Message-ID: <1536604521.22056.20.camel@impinj.com> (raw)
In-Reply-To: <20180904183934.12291-1-aduskett@gmail.com>
On Tue, 2018-09-04 at 14:39 -0400, Adam Duskett wrote:
> qemu 2.12.0 now supports building against python3.
> see: https://wiki.qemu.org/ChangeLog/2.12#Build_Dependencies
>
> Signed-off-by: Adam Duskett <aduskett@gmail.com>
> ---
> Changes v1 -> v2:
> - Split the python version check into two seperate checks for
> readability, one for the target, one for the host.
> - Fix location of the python version check for target and host.
>
> +ifeq ($(BR2_PACKAGE_PYTHON3),y)
> +HOST_QEMU_DEPENDENCIES += host-python3
> +HOST_QEMU_CONFIGURE_CMDS += --python=$(HOST_DIR)/bin/python3
> +else
> +HOST_QEMU_DEPENDENCIES += host-python
> +HOST_QEMU_CONFIGURE_CMDS += --python=$(HOST_DIR)/bin/python2
> +endif
This will mean that if the target system does not have python at all,
then one is forced to use host python 2.
Which is an existing buildroot problem. But I wish it could be fixed
instead of further ingraining the concept of "host python version is
target python version or python 2 if no target python." Because that
concept just isn't right.
prev parent reply other threads:[~2018-09-10 18:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-04 18:39 [Buildroot] [PATCH v2 1/1] qemu: add support for python3 Adam Duskett
2018-09-04 18:47 ` Baruch Siach
2018-09-04 19:09 ` Adam Duskett
2018-09-05 3:59 ` Baruch Siach
2018-09-05 16:43 ` Adam Duskett
2018-09-05 17:47 ` Baruch Siach
2018-09-06 7:50 ` Thomas Petazzoni
2018-09-06 22:58 ` Hollis Blanchard
2018-09-06 19:32 ` Thomas Petazzoni
2018-09-10 18:35 ` Trent Piepho [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1536604521.22056.20.camel@impinj.com \
--to=tpiepho@impinj.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox