From: Trent Piepho <tpiepho@impinj.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] gnupg: Package only needs ncurses with readline
Date: Wed, 3 Oct 2018 00:25:19 +0000 [thread overview]
Message-ID: <1538526319.6709.28.camel@impinj.com> (raw)
In-Reply-To: <20181002053850.uguwwwry2wx37hp6@sapphire.tkos.co.il>
On Tue, 2018-10-02 at 08:38 +0300, Baruch Siach wrote:
> @@ -2,7 +2,7 @@ config BR2_PACKAGE_GNUPG
> > bool "gnupg"
> > depends on !BR2_PACKAGE_GNUPG2
> > select BR2_PACKAGE_ZLIB
> > - select BR2_PACKAGE_NCURSES
> > + select BR2_PACKAGE_NCURSES if BR2_PACKAGE_READLINE
>
> BR2_PACKAGE_READLINE selects BR2_PACKAGE_NCURSES already, so this is not
> needed.
Ok, I can take it out. I thought since the gnupg configure script
directly references ncurses (when looking for readline), there should
be a direct dependency from gnupg to ncurses, rather than depending on
that dependency being there indirectly. I.e., what if someone changes
readline's dependencies, would they consider the effect on gnupg?
But perhaps since it's part of readline support that is not necessary.
prev parent reply other threads:[~2018-10-03 0:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-28 23:18 [Buildroot] [PATCH] gnupg: Package only needs ncurses with readline Trent Piepho
2018-10-02 5:38 ` Baruch Siach
2018-10-03 0:25 ` Trent Piepho [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1538526319.6709.28.camel@impinj.com \
--to=tpiepho@impinj.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox