From mboxrd@z Thu Jan  1 00:00:00 1970
From: Titouan Christophe <titouan.christophe@railnova.eu>
Date: Mon, 04 Feb 2019 17:34:01 +0100
Subject: [Buildroot] [PATCH v1] package/qt5/qt5base: handle
 sse2/sse3/ssse3/sse4.1/sse4.2/avx/avx2 configuration
In-Reply-To: <20190201202452.11724-1-ps.report@gmx.net>
References: <20190201202452.11724-1-ps.report@gmx.net>
Message-ID: <1549298041.7318.53.camel@railnova.eu>
List-Id: <buildroot.busybox.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: buildroot@busybox.net

Hi Peter,

On Fri, 2019-02-01 at 21:24 +0100, Peter Seiderer wrote:
> The Qt configure auto detection (and anounced runtime detection
> feature) failes (see e.g. [1]), so override the configuration
> with the buildroot determined settings.
> 
> [1] http://lists.busybox.net/pipermail/buildroot/2019-January/241862.
> html
> 
> Reported-by: David Picard <dplamp@gmx.com>
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
> Notes:
>  - suggested by Arnout Vandecappelle [2]
> 
> [2] http://lists.busybox.net/pipermail/buildroot/2019-January/242030.
> html
> ---
>  package/qt5/qt5base/qt5base.mk | 31 +++++++++++++++++++++++++++++++
>  1 file changed, 31 insertions(+)
> 
> diff --git a/package/qt5/qt5base/qt5base.mk
> b/package/qt5/qt5base/qt5base.mk
> index d10f233b46..b84efcc2bf 100644
> --- a/package/qt5/qt5base/qt5base.mk
> +++ b/package/qt5/qt5base/qt5base.mk
> @@ -33,6 +33,37 @@ else
>  QT5BASE_DEPENDENCIES += pcre2
>  endif
>  
> +ifeq ($(BR2_X86_CPU_HAS_SSE2),)
> +QT5BASE_CONFIGURE_OPTS += -no-sse2
> +else
> +ifeq ($(BR2_X86_CPU_HAS_SSE3),)
> +QT5BASE_CONFIGURE_OPTS += -no-sse3
> +else
> +ifeq ($(BR2_X86_CPU_HAS_SSSE3),)
> +QT5BASE_CONFIGURE_OPTS += -no-ssse3
> +else
> +ifeq ($(BR2_X86_CPU_HAS_SSE4),)
> +QT5BASE_CONFIGURE_OPTS += -no-sse4.1
> +else
> +ifeq ($(BR2_X86_CPU_HAS_SSE42),)
> +QT5BASE_CONFIGURE_OPTS += -no-sse4.2
> +else
> +ifeq ($(BR2_X86_CPU_HAS_AVX),)
> +QT5BASE_CONFIGURE_OPTS += -no-avx
> +else
> +ifeq ($(BR2_X86_CPU_HAS_AVX2),)
> +QT5BASE_CONFIGURE_OPTS += -no-avx2
> +else
> +# no BR2_X86_CPU_HAS_AVX512 for qt configure option
> +# '-no-avx512' (available for latest)
> +endif
> +endif
> +endif
> +endif
> +endif
> +endif
> +endif

Does -no-sse2 implies -no-sse3, -no-ssse3, ... and so on and so forth ?
This is not very clear from the docs I found.

> +
>  QT5BASE_CONFIGURE_OPTS += $(call
> qstrip,$(BR2_PACKAGE_QT5BASE_CUSTOM_CONF_OPTS))
>  
>  ifeq ($(BR2_PACKAGE_LIBDRM),y)


Otherwise looks reasonable.

Have a nice Monday !

Titouan