From: Paul Cercueil <paul@crapouillou.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] umtprd: Add package
Date: Wed, 13 Nov 2019 12:16:41 +0100 [thread overview]
Message-ID: <1573643801.3.4@crapouillou.net> (raw)
In-Reply-To: <20191107220929.2645c47b@windsurf>
Hi Thomas,
Le jeu., nov. 7, 2019 at 22:09, Thomas Petazzoni
<thomas.petazzoni@bootlin.com> a ?crit :
> Hello Paul,
>
> Some comments in addition to the ones done by Baruch and Yann.
>
> On Thu, 7 Nov 2019 17:45:13 +0100
> Paul Cercueil <paul@crapouillou.net> wrote:
>
>> package/Config.in | 1 +
>> ...thread.h-include-in-inc-mtp.h-header.patch | 28
>> +++++++++++++++++++
>> package/umtprd/Config.in | 6 ++++
>> package/umtprd/umtprd.hash | 2 ++
>> package/umtprd/umtprd.mk | 20 +++++++++++++
>> 5 files changed, 57 insertions(+)
>
> You should add an entry in the DEVELOPERS file.
>
>
>> diff --git a/package/umtprd/umtprd.hash b/package/umtprd/umtprd.hash
>> new file mode 100644
>> index 0000000000..aa91696613
>> --- /dev/null
>> +++ b/package/umtprd/umtprd.hash
>> @@ -0,0 +1,2 @@
>> +# Locally computed
>>
>> +sha256 e1301bdd89170cc2c679446c1cc5873feaacd061bf0ab547fc0a11670bae9163 umtprd-1.0.0.tar.gz
>
> Please add a hash for the license file.
>
>> diff --git a/package/umtprd/umtprd.mk b/package/umtprd/umtprd.mk
>> new file mode 100644
>> index 0000000000..8460f82b7d
>> --- /dev/null
>> +++ b/package/umtprd/umtprd.mk
>> @@ -0,0 +1,20 @@
>>
>> +################################################################################
>> +#
>> +# umtprd
>> +#
>>
>> +################################################################################
>> +
>> +UMTPRD_VERSION = 1.0.0
>> +UMTPRD_SITE = https://github.com/viveris/uMTP-Responder/archive
>
> It is never clear to me if those URLs are auto-generated tarballs, or
> tarballs produced by the project maintainer and uploaded to Github. If
> these are auto-generated tarballs, then the "github" macro should be
> used instead.
It's a release manually uploaded to github, that's why I didn't use the
"github" macro.
Cheers,
-Paul
>
> Thanks,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
next prev parent reply other threads:[~2019-11-13 11:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-07 16:45 [Buildroot] [PATCH] umtprd: Add package Paul Cercueil
2019-11-07 17:05 ` Baruch Siach
2019-11-07 17:55 ` Yann E. MORIN
2019-11-07 21:09 ` Thomas Petazzoni
2019-11-13 11:16 ` Paul Cercueil [this message]
2019-11-17 17:16 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1573643801.3.4@crapouillou.net \
--to=paul@crapouillou.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox