Re: [Buildroot] [PATCH v2 1/3] package/targetcli-fb: bump version to 2.1.58

["Jeremy J. Peper" <jeremy@jeremypeper.com>]

On Saturday, March 16, 2024 2:21:35 PM CDT Arnout Vandecappelle wrote:
> On 15/03/2024 23:21, Jeremy J. Peper wrote:
> > On Friday, March 15, 2024 3:31:09 PM CDT Arnout Vandecappelle wrote:
> >>    Hi Jeremy,
> >> 
> >> On 12/03/2024 20:35, Jeremy J. Peper wrote:
> >>> bump to latest version because previous version did not work with python
> >>> 3.11 corrected version mismatch with my first submission
> >>> 
> >>    I unfortunately already pushed before I noticed: you shouldn't include
> >> 
> >> "personal comments" or references to the patch history in the commit
> >> message itself - that belongs under the --- line. So it should have
> >> been:
> >> 
> >> package/targetcli-fb: bump version to 2.1.58
> >> 
> >> Bump to latest version because previous version did not work with python
> >> 3.11
> >> 
> >> Signed-off-by: ...
> >> ---
> >> v2: correct version mismatch
> > 
> > Sorry about that, I will endeavour to do that properly in the future.
> 
>   No worries. I made this comment so you could learn.
> 
> >>    And another thing: we've had Python 3.11 for more than a year, so this
> >>    has
> >> 
> >> been broken for quite some time. To make sure we notice in the future, it
> >> would be good to have a runtime test that detects the situation.
> >> 
> >>    Regards,
> >>    Arnout
> > 
> > I believe you are correct, it appears to have been broken for at least the
> > past few stable releases.
> > 
> > Adding the test sounds like a good idea and I'd be interested in setting
> > that up at some point but I'm not sure when I'll get a chance to work
> > through that learning curve.
> 
>   For a Python package, the test is usually quite simple: just import it,
> and if there's a C library linked with it, make sure you make a call into
> the C library. See e.g. support/testing/tests/package/test_python_click.py
> 
>   A slightly more complicated test can import a Python script to do the
> actual test. See e.g. support/testing/tests/package/test_python_gnupg.py
> which runs support/testing/tests/package/sample_python_gnupg.py
> 
> [snip]
> 
> > Are there any other changes that I need to make before this is suitable to
> > be committed?
> 
>   I apparently didn't make my self clear enough: it is already committed
> (that's why I said "I already pushed"). In fact, the entire series is
> committed.
> 
> 
>   Regards,
>   Arnout
> 
> > Thanks again for all your feedback and guidance.
> > -Jeremy

Excellent, is it possible to get this fix added to the next release of 
2024.02.x ?



_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot