From: Ricardo Martincoski <ricardo.martincoski@datacom.ind.br>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] support/scripts/pkg-stats: flake8 print() cleanup
Date: Fri, 18 May 2018 17:32:17 -0300 (BRT) [thread overview]
Message-ID: <1640465213.1400009.1526675537608.JavaMail.zimbra@datacom.com.br> (raw)
In-Reply-To: <1526648700-15130-1-git-send-email-matthew.weber@rockwellcollins.com>
Hello,
On Friday, May 18, 2018 10:05:00 AM, Matt Weber wrote:
> support/scripts/pkg-stats: flake8 print() cleanup
AFAIK flake8 doesn't warn about this yet. Maybe this is a better title:
support/scripts/pkg-stats: add parenthesis for print
Also mentioning it is related to Python 3 in the commit log would be good:
Use Python3-style "print".
> Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>
If we want to support Python 2.6 for old distros this would also be needed:
from __future__ import print_function
But supporting old distros is important for scripts that run *during* the build
process, so I think we don't need to do this in this case.
[The commit title/message can be improved while applying;
I assume we don't need to support Python 2.6 for this script, only for scripts
that run during the build process.]
Reviewed-by: Ricardo Martincoski <ricardo.martincoski@datacom.ind.br>
Regards,
Ricardo
next prev parent reply other threads:[~2018-05-18 20:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-18 13:05 [Buildroot] [PATCH] support/scripts/pkg-stats: flake8 print() cleanup Matt Weber
2018-05-18 20:32 ` Ricardo Martincoski [this message]
2018-05-19 11:50 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1640465213.1400009.1526675537608.JavaMail.zimbra@datacom.com.br \
--to=ricardo.martincoski@datacom.ind.br \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox