From: Kris Bahnsen via buildroot <buildroot@buildroot.org>
To: Giulio Benetti <giulio.benetti@benettiengineering.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/wilc-driver: fix build failure due to missing Linux options
Date: Tue, 20 Sep 2022 10:01:48 -0700 [thread overview]
Message-ID: <1663693308.2395.5.camel@embeddedTS.com> (raw)
In-Reply-To: <20220920133224.3290270-1-giulio.benetti@benettiengineering.com>
On Tue, 2022-09-20 at 15:32 +0200, Giulio Benetti wrote:
> Enable Linux options depending on the bus has been chosen, so:
> 1) enable by default common Linux options:
> CONFIG_NET
> CONFIG_WIRELESS
> CONFIG_CFG80211
> CONFIG_CRC_ITU_T
> CONFIG_CRC7
> 2) enable for SDIO bus:
> CONFIG_MMC
> 3) enable for SPI bus:
> CONFIG_SPI
>
> Fixes:
> http://autobuild.buildroot.net/results/d8c4f0f959dd2ec110db8a75980f13172c3c116c/
>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> package/wilc-driver/wilc-driver.mk | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/package/wilc-driver/wilc-driver.mk b/package/wilc-driver/wilc-driver.mk
> index a89af30e29..a7a902b6db 100644
> --- a/package/wilc-driver/wilc-driver.mk
> +++ b/package/wilc-driver/wilc-driver.mk
> @@ -13,11 +13,17 @@ WILC_DRIVER_LICENSE_FILES = LICENSE
> ifeq ($(BR2_PACKAGE_WILC_DRIVER_SPI),y)
> WILC_DRIVER_MODULE_MAKE_OPTS += \
> CONFIG_WILC_SPI=m
> +define WILC_DRIVER_SPI_LINUX_CONFIG_FIXUPS
> + $(call KCONFIG_ENABLE_OPT,CONFIG_SPI)
> +endef
> endif
>
> ifeq ($(BR2_PACKAGE_WILC_DRIVER_SDIO),y)
> WILC_DRIVER_MODULE_MAKE_OPTS += \
> CONFIG_WILC_SDIO=m
> +define WILC_DRIVER_SDIO_LINUX_CONFIG_FIXUPS
> + $(call KCONFIG_ENABLE_OPT,CONFIG_MMC)
> +endef
> endif
>
> ifeq ($(BR2_PACKAGE_WILC_DRIVER_SDIO_OOB),y)
> @@ -25,5 +31,15 @@ WILC_DRIVER_MODULE_MAKE_OPTS += \
> CONFIG_WILC_HW_OOB_INTR=y
> endif
>
> +define WILC_DRIVER_LINUX_CONFIG_FIXUPS
> + $(call KCONFIG_ENABLE_OPT,CONFIG_NET)
> + $(call KCONFIG_ENABLE_OPT,CONFIG_WIRELESS)
> + $(call KCONFIG_ENABLE_OPT,CONFIG_CFG80211)
> + $(call KCONFIG_ENABLE_OPT,CONFIG_CRC_ITU_T)
> + $(call KCONFIG_ENABLE_OPT,CONFIG_CRC7)
> + $(WILC_DRIVER_SPI_LINUX_CONFIG_FIXUPS)
> + $(WILC_DRIVER_SDIO_LINUX_CONFIG_FIXUPS)
> +endef
> +
> $(eval $(kernel-module))
> $(eval $(generic-package))
Reviewed-by: Kris Bahnsen <Kris@embeddedTS.com>
Thanks for that! I was not readily aware of that syntax for kernel config fixups.
I've also added auto-builds to my filter exception rules so I should be able
to more readily look those over in the future.
-Kris
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-09-20 17:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 13:32 [Buildroot] [PATCH] package/wilc-driver: fix build failure due to missing Linux options Giulio Benetti
2022-09-20 17:01 ` Kris Bahnsen via buildroot [this message]
2022-09-20 17:20 ` Giulio Benetti
2022-11-24 21:58 ` Thomas Petazzoni via buildroot
2022-12-05 21:31 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1663693308.2395.5.camel@embeddedTS.com \
--to=buildroot@buildroot.org \
--cc=giulio.benetti@benettiengineering.com \
--cc=kris@embeddedTS.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox