Re: [Buildroot] [PATCH 7/7] package/wilc-driver: disable package for s390x architecture

From: Kris Bahnsen via buildroot <buildroot@buildroot.org>
To: Giulio Benetti <giulio.benetti@benettiengineering.com>,
	 buildroot@buildroot.org
Cc: Louis Aussedat <aussedat.louis@gmail.com>,
	Angelo Compagnucci <angelo.compagnucci@gmail.com>,
	Sergey Matyukevich <geomatsi@gmail.com>
Subject: Re: [Buildroot] [PATCH 7/7] package/wilc-driver: disable package for s390x architecture
Date: Wed, 26 Oct 2022 10:32:28 -0700	[thread overview]
Message-ID: <1666805548.3174.1.camel@embeddedTS.com> (raw)
In-Reply-To: <20221026132634.999254-8-giulio.benetti@benettiengineering.com>

On Wed, 2022-10-26 at 15:26 +0200, Giulio Benetti wrote:
> s390x doesn't support CONFIG_WIRELESS in Linux so let's disable this
> package for this architecture.
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
>  package/wilc-driver/Config.in | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/package/wilc-driver/Config.in b/package/wilc-driver/Config.in
> index 7ed062bb66..7f970bd38b 100644
> --- a/package/wilc-driver/Config.in
> +++ b/package/wilc-driver/Config.in
> @@ -1,5 +1,6 @@
>  config BR2_PACKAGE_WILC_DRIVER
>  	bool "wilc kernel module"
> +	depends on !BR2_s390x
>  	depends on BR2_LINUX_KERNEL
>  	help
>  	  External kernel module for WILC1000/3000 devices.
> @@ -59,4 +60,5 @@ endif
>  endif
>  
>  comment "wilc kernel module needs a Linux kernel to be built"
> +	depends on !BR2_s390x
>  	depends on !BR2_LINUX_KERNEL

I don't know much on the s390x arch, nor Buildroot paradigms for disabling packages
per-architecture, however the change itself looks good to me.

Reviewed-by: Kris Bahnsen <kris@embeddedTS.com>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot