From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BD93BC46467 for ; Mon, 2 Jan 2023 19:30:10 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 9A41F81418; Mon, 2 Jan 2023 19:30:09 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 9A41F81418 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6_knVOw4f4Lq; Mon, 2 Jan 2023 19:30:08 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id D15BE812ED; Mon, 2 Jan 2023 19:30:05 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org D15BE812ED Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 2DE7C1BF2A9 for ; Mon, 2 Jan 2023 19:30:04 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 0F9BF8129A for ; Mon, 2 Jan 2023 19:30:04 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 0F9BF8129A X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XYOaP-HdtmjU for ; Mon, 2 Jan 2023 19:30:02 +0000 (UTC) X-Greylist: delayed 00:05:01 by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org B6F078127D Received: from smtp-out3.electric.net (smtp-out3.electric.net [208.70.128.179]) by smtp1.osuosl.org (Postfix) with ESMTPS id B6F078127D for ; Mon, 2 Jan 2023 19:30:02 +0000 (UTC) Received: from 1pCQQd-0007pp-Ta by out3d.electric.net with emc1-ok (Exim 4.94.2) (envelope-from ) id 1pCQQd-0007qW-W5; Mon, 02 Jan 2023 11:24:59 -0800 Received: by emcmailer; Mon, 02 Jan 2023 11:24:59 -0800 Received: from [66.210.251.27] (helo=mail.embeddedts.com) by out3d.electric.net with esmtps (TLS1.2) tls TLS_DHE_RSA_WITH_SEED_CBC_SHA (Exim 4.94.2) (envelope-from ) id 1pCQQd-0007pp-Ta; Mon, 02 Jan 2023 11:24:59 -0800 Received: from tsdebian (unknown [75.164.37.1]) by mail.embeddedts.com (Postfix) with ESMTPSA id A53E35ABE; Mon, 2 Jan 2023 12:24:58 -0700 (MST) Message-ID: <1672687476.3896.3.camel@embeddedTS.com> To: Giulio Benetti , buildroot@buildroot.org Date: Mon, 02 Jan 2023 11:24:36 -0800 In-Reply-To: <20221228205323.71420-1-giulio.benetti@benettiengineering.com> References: <20221228205323.71420-1-giulio.benetti@benettiengineering.com> Organization: embeddedTS X-Mailer: Evolution 3.22.6-1+deb9u2 Mime-Version: 1.0 X-Outbound-IP: 66.210.251.27 X-Env-From: kris@embeddedTS.com X-Proto: esmtps X-Revdns: wsip-66-210-251-27.ph.ph.cox.net X-HELO: mail.embeddedts.com X-TLS: TLS1.2:DHE-RSA-SEED-SHA:128 X-Authenticated_ID: X-VIPRE-Scanners: virus_bd;virus_clamav; X-FM-Delivery-Delay: 15749372,23518412 X-PolicySMART: 13164782, 15749372, 26810492 X-FM-Delivery-Delay: 15749372,23518412 X-PolicySMART: 13164782, 15749372, 26810492 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedTS.com; s=mailanyone20220121; h=Mime-Version:References:In-Reply-To:Date:To:From:Message-ID; bh=55EwVnRXPuAHwdLTzuX9mZyT8o6BY2sWIEeTsl37hKk=; b=aXaWIPDOCihH39lbRmCX6gUqT++xGVrlP/IUzHTLJjPgIKkHhNXfyTVD/4DOK9EMKWjgQ+uDevu5Hc0+H4UVgN0TlTZ0JIChvuHYkHs3q+stifw+q5pUHHDgJsIXNz33KtAE/mos2O8UNIpg54r4Jh2VkuaHC0Izoh5EP0uLHriHyoVUR3evUzrZSTCU0QFy4N97lOdiepI1bqgPUzCbFxQtD0s/A5qOMyzVZP2ojImCBMRWVdzS1WtEDnp9OkmYzTCXsUohisxcUL4IMjtkztzUJrdeW3VLhLd/1YDeKjWtal3X7HaX2v3HlCR0HWZcp5tggX+A75O65uLEUFsCxA==; X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key) header.d=embeddedTS.com header.i=@embeddedTS.com header.a=rsa-sha256 header.s=mailanyone20220121 header.b=aXaWIPDO Subject: Re: [Buildroot] [PATCH] package/wilc-driver: fix build failure up to Linux 6.1 X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Kris Bahnsen via buildroot Reply-To: kris@embeddedTS.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" On Wed, 2022-12-28 at 21:53 +0100, Giulio Benetti wrote: > Add patches pending upstream[0] to handle various data types and api > changes up to Linux 6.1. > > [0]: https://github.com/embeddedTS/wilc3000-external-module/pull/2 > > Fixes: > http://autobuild.buildroot.net/results/6aa7475a21a6060e9fce3552f73e6e7100a8b2aa > > Signed-off-by: Giulio Benetti > --- > ...missing-prandom_u32-with-Linux-6.1.0.patch | 34 +++ > ...fix-build-failure-on-remove-callback.patch | 44 ++++ > ...uild-failure-with-Linux-5.19-and-6.1.patch | 98 ++++++++ > ...on_parameters-Linux-6.1-build-failur.patch | 216 ++++++++++++++++++ > 4 files changed, 392 insertions(+) > create mode 100644 package/wilc-driver/0001-cfg80211.c-fix-missing-prandom_u32-with-Linux-6.1.0.patch > create mode 100644 package/wilc-driver/0002-spi.c-fix-build-failure-on-remove-callback.patch > create mode 100644 package/wilc-driver/0003-cfg80211.c-fix-build-failure-with-Linux-5.19-and-6.1.patch > create mode 100644 package/wilc-driver/0004-Fix-struct-station_parameters-Linux-6.1-build-failur.patch > Giulio, all, I figure this is the most appropriate place to have a discussion on this topic as these patches were also pushed to our github repo: https://github.com/embeddedTS/wilc3000-external-module/ I want to note that we are not intending on doing any maintenance or patch work on this driver, except to keep this driver functional on our platforms. It is maintained as a buildable external module of this folder tree: https://github.com/linux4sam/linux-at91/tree/master/drivers/net/wireless/microchip We did this because during the Microchip takeover they abandoned their maintained external tree as well as halted any plans to bring WILC3000 support to the kernel upstream. Our fork gives us easy access to building the modules without having to keep pulling changes in to all of our kernels. I'm not sure the best way to go about handling these patches as Microchip is currently only maintaining support for 5.15 it appears. I also don't want to pollute our external module tree with fixes that arn't in the upstream we're pulling in. Giulio, would you be willing to attempt pushing these changes to the Microchip repo? Does it make more sense to just leave these as patches to the driver in Buildroot? Would it make sense to instead apply some limits to the package or external module to only build on already compatible kernel versions? -Kris _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot