From: Julien Olivain via buildroot <buildroot@buildroot.org>
To: Michael Nosthoff <buildroot@heine.tech>
Cc: buildroot@buildroot.org,
James Hilliard <james.hilliard1@gmail.com>,
Asaf Kahlon <asafka7@gmail.com>
Subject: Re: [Buildroot] [PATCH] package/{python-}protobuf: bump to version 34.0
Date: Sun, 08 Mar 2026 22:55:22 +0100 [thread overview]
Message-ID: <171fa9c539e7192d6e1006e23e08c370@free.fr> (raw)
In-Reply-To: <20260303083702.2275652-2-buildroot@heine.tech>
Hi Michael,
Thanks for the patch.
On 03/03/2026 09:36, Michael Nosthoff via buildroot wrote:
> - contains breaking changes, hence python major version is bumped to 7.
>
> Changelog:
> https://github.com/protocolbuffers/protobuf/releases/tag/v34.0
>
> Signed-off-by: Michael Nosthoff <buildroot@heine.tech>
> ---
[...]
> diff --git a/package/protobuf/protobuf.mk
> b/package/protobuf/protobuf.mk
> index b2046e057b..1d110fdbf0 100644
> --- a/package/protobuf/protobuf.mk
> +++ b/package/protobuf/protobuf.mk
> @@ -7,7 +7,7 @@
> # When bumping this package, make sure to also verify if the
> # python-protobuf package still works and to update its hash,
> # as they share the same version/site variables.
> -PROTOBUF_VERSION = 33.5
> +PROTOBUF_VERSION = 34.0
This new version breaks the build of protobuf-c. You can
reproduce the issue with the command:
make host-protobuf-c
It fails with the error:
protoc-gen-c/c_bytes_field.cc:97:24: error: ‘const class
google::protobuf::FieldDescriptor’ has no member named ‘label’; did you
mean ‘Label’?
See also:
https://github.com/protobuf-c/protobuf-c/issues/795
I'd like to merge that patch only when protobuf-c will be
able to compile with this new protobuf version.
Could you have a look, please?
Best regards,
Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2026-03-08 21:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-03 8:36 [Buildroot] [PATCH] package/{python-}protobuf: bump to version 34.0 Michael Nosthoff via buildroot
2026-03-08 21:55 ` Julien Olivain via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171fa9c539e7192d6e1006e23e08c370@free.fr \
--to=buildroot@buildroot.org \
--cc=asafka7@gmail.com \
--cc=buildroot@heine.tech \
--cc=james.hilliard1@gmail.com \
--cc=ju.o@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox