From: Francesco Nwokeka <francesco.nwokeka@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 1/1] package/at: updated version from 3.1.13 to 3.1.16
Date: Thu, 22 Oct 2015 12:31:39 +0200 [thread overview]
Message-ID: <1913530.deddMt05TU@deathstar> (raw)
In-Reply-To: <20150920150838.1009ed2d@free-electrons.com>
On Sunday 20 September 2015 15:08:38 Thomas Petazzoni wrote:
> Dear Francesco Nwokeka,
>
> On Tue, 08 Sep 2015 14:13:59 +0200, Francesco Nwokeka wrote:
> > Version 3 of the patch to update the "at" package.
>
> You received some comments from Arnout Vandecappelle on September 8th
> on this patch. Could you take them into account and send an updated
> version of the patch?
>
> I was going to apply by fixing the problems pointed by Arnout, but one
> requires a bit more work:
>
> """
> > * Merged previous Makefile.in patches into one.
>
> Ick, that's not what I intended! We want a separate patch file for each
> separate change. The two patches that you squashed into one do two
> distinct changes:
>
> - change IROOT into DESTDIR
> - don't try to install as root
>
> So it's good to keep them separate.
>
> My proposal was to drop the first patch and just use IROOT. In
> buildroot, we can easily use IROOT instead of DESTDIR by setting
>
> AT_INSTALL_TARGET_OPTS = IROOT=$(TARGET_DIR) install
> """
>
> Could you fix that and send a new version?
Hi Thomas!
Sorry for the late reply but I've been 100% busy during this period. I'll get the patch back up and running ASAP. Sorry for the delay
Thanks,
Francesco
> Thanks,
>
> Thomas
>
prev parent reply other threads:[~2015-10-22 10:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-07 13:05 [Buildroot] [PATCH v2 1/1] package/at: updated version from 3.1.13 to 3.1.16 Francesco Nwokeka
[not found] ` <55EDE328.5020802@mind.be>
[not found] ` <6141234.WAqyL1Ty6r@deathstar>
2015-09-08 8:01 ` Arnout Vandecappelle
2015-09-08 12:13 ` [Buildroot] [PATCH v3 " Francesco Nwokeka
2015-09-08 13:57 ` Arnout Vandecappelle
2015-09-20 13:08 ` Thomas Petazzoni
2015-10-22 10:31 ` Francesco Nwokeka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1913530.deddMt05TU@deathstar \
--to=francesco.nwokeka@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox