Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/2] c-ares: support host build
Date: Sun, 18 Nov 2018 22:37:24 +0100	[thread overview]
Message-ID: <1b557238-e153-5b9c-646f-e188deb8e41b@mind.be> (raw)
In-Reply-To: <8b5155dd-c5e5-570f-69ca-6f3a9ecc149c@mind.be>

?D'oh

On 18/11/2018 22:33, Arnout Vandecappelle wrote:
>  Hi Robert,
>
> On 18/11/2018 22:19, Robert Rose wrote:
>> Signed-off-by: Robert Rose <robertroyrose@gmail.com>
>> ---
>>  package/c-ares/c-ares.mk | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/package/c-ares/c-ares.mk b/package/c-ares/c-ares.mk
>> index 67254244a1..76e9687b37 100644
>> --- a/package/c-ares/c-ares.mk
>> +++ b/package/c-ares/c-ares.mk
>> @@ -15,3 +15,4 @@ C_ARES_LICENSE = MIT
>>  C_ARES_LICENSE_FILES = ares_mkquery.c
>>  
>>  $(eval $(autotools-package))
>> +$(eval $(host-autotools-package))
>  We only include host packages if there is a justification for it. That means
> either:
>
> - it is needed for building some other package; in this case, you should submit
> the patch adding the host package in a series together with the other package; or

?Sorry, patch 2/2 hadn't arrived yet when I was writing this, and I hadn't
noticed the 1/2 in the subject. Obviously it's this situation.


?So:

Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>


?I'd like to add that there is no need to specify the --with-random option for
the host like we do for the target, because for the host it can be autodiscovered.


?Regards,
?Arnout


>
> - it is used in a post-{build,fakeroot,image} script; in that case, there should
> be a Config.in.host option for it so it can be selected, and the commit log
> should have some explanation of why it could be useful in a post-* script.
>
>
>  Regards,
>  Arnout

      reply	other threads:[~2018-11-18 21:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-18 21:19 [Buildroot] [PATCH v2 1/2] c-ares: support host build Robert Rose
2018-11-18 21:19 ` [Buildroot] [PATCH v2 2/2] grpc: new package Robert Rose
2018-11-24 14:12   ` Thomas Petazzoni
     [not found]     ` <CALxq1w45Krr6E8Ri7rxrDN9USkbPdLbqmmK2x-XiH3AmHHeqpg@mail.gmail.com>
2018-11-24 20:45       ` Thomas Petazzoni
2018-11-24 22:00         ` robert rose
2018-11-24 23:57           ` robert rose
2018-11-26 21:58             ` Thomas Petazzoni
2018-11-27 17:17   ` Arnout Vandecappelle
2018-11-18 21:33 ` [Buildroot] [PATCH v2 1/2] c-ares: support host build Arnout Vandecappelle
2018-11-18 21:37   ` Arnout Vandecappelle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1b557238-e153-5b9c-646f-e188deb8e41b@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox