Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Olivain <ju.o@free.fr>
To: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Cc: buildroot@buildroot.org, Niklas Cassel <niklas.cassel@wdc.com>,
	linux-amarula@amarulasolutions.com
Subject: Re: [Buildroot] [RFC PATCH v2 1/1] package/pkg-download: don't export the download command variables
Date: Thu, 13 Feb 2025 22:23:22 +0100	[thread overview]
Message-ID: <1da1969f3e232db05ab1622415b2dec7@free.fr> (raw)
In-Reply-To: <20250213180908.3963679-1-dario.binacchi@amarulasolutions.com>

Hi Dario, All,

On 13/02/2025 19:09, Dario Binacchi wrote:
> Exporting the download variables can cause unfortunate name clashes, as
> occurred with the SCP variable used by Binman for compiling U-Boot [1].
> Do not globally export the package download commands anymore; instead,
> pass them to the dl-wrapper environment.
> 
> [1] 
> https://lore.kernel.org/buildroot/a023971c7c8bfa4826a9a8721500c7ff@free.fr/T/
> Cc: Julien Olivain <ju.o@free.fr>
> Suggested-by: Peter Korsgaard <peter@korsgaard.com>
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>

I applied the patch to master. I did few minor changes, see:
https://gitlab.com/buildroot.org/buildroot/-/commit/56cc6fa2c71eff27efcb66d60f254da04439ac18

Thank you for your patience and perseverance!

Best regards,

Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2025-02-13 21:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-13 18:09 [Buildroot] [RFC PATCH v2 1/1] package/pkg-download: don't export the download command variables Dario Binacchi
2025-02-13 21:23 ` Julien Olivain [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1da1969f3e232db05ab1622415b2dec7@free.fr \
    --to=ju.o@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=dario.binacchi@amarulasolutions.com \
    --cc=linux-amarula@amarulasolutions.com \
    --cc=niklas.cassel@wdc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox