From: Fiona Klute via buildroot <buildroot@buildroot.org>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Fiona Klute via buildroot <buildroot@buildroot.org>
Cc: Julien Olivain <ju.o@free.fr>,
Ricardo Martincoski <ricardo.martincoski@datacom.com.br>
Subject: Re: [Buildroot] [PATCH v2 5/6] support/testing: include init script in iptables test
Date: Tue, 23 Jul 2024 15:41:20 +0200 [thread overview]
Message-ID: <1f14d0f9-1749-4abd-bf08-1b281a02de75@gmx.de> (raw)
In-Reply-To: <20240723142600.6be4c23c@windsurf>
Am 23.07.24 um 14:26 schrieb Thomas Petazzoni:
> Hello Fiona,
>
> Thanks for this patch series!
>
> On Tue, 23 Jul 2024 12:28:30 +0200
> Fiona Klute via buildroot <buildroot@buildroot.org> wrote:
>
>> From: "Fiona Klute (WIWA)" <fiona.klute@gmx.de>
>>
>> Check a save/start/stop cycle based on the rules created by direct
>> commands in the pre-existing test.
>>
>> Signed-off-by: Fiona Klute (WIWA) <fiona.klute@gmx.de>
>> ---
>> package/iptables/S35iptables | 2 +-
>> support/testing/tests/package/test_iptables.py | 18 ++++++++++++++++++
>> 2 files changed, 19 insertions(+), 1 deletion(-)
>>
>> diff --git a/package/iptables/S35iptables b/package/iptables/S35iptables
>> index a67d0886a9..d6ff4a4762 100644
>> --- a/package/iptables/S35iptables
>> +++ b/package/iptables/S35iptables
>> @@ -23,7 +23,7 @@ start() {
>>
>> stop() {
>> printf 'Stopping %s: ' "$DAEMON"
>> - iptables -F
>> + iptables --flush
>
> I suppose this change was not meant to be in this patch, but probably
> in an earlier patch of the series?
Right, thanks for catching that. I've just sent v3 with that fixed.
Sorry about the noise!
Best regards,
Fiona
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-07-23 13:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-23 10:28 [Buildroot] [PATCH v2 0/6] Improved nftables firewall support Fiona Klute via buildroot
2024-07-23 10:28 ` [Buildroot] [PATCH v2 1/6] package/nftables: add init script Fiona Klute via buildroot
2024-07-23 10:28 ` [Buildroot] [PATCH v2 2/6] package/iptables: optionally default to nftables compat Fiona Klute via buildroot
2024-07-23 10:28 ` [Buildroot] [PATCH v2 3/6] package/iptables: check for rules in init script Fiona Klute via buildroot
2024-07-23 10:28 ` [Buildroot] [PATCH v2 4/6] support/testing: test for nftables " Fiona Klute via buildroot
2024-07-23 10:28 ` [Buildroot] [PATCH v2 5/6] support/testing: include init script in iptables test Fiona Klute via buildroot
2024-07-23 12:26 ` Thomas Petazzoni via buildroot
2024-07-23 13:41 ` Fiona Klute via buildroot [this message]
2024-07-23 10:28 ` [Buildroot] [PATCH v2 6/6] support/testing: fix MyPy warnings about BRConfigTest Fiona Klute via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f14d0f9-1749-4abd-bf08-1b281a02de75@gmx.de \
--to=buildroot@buildroot.org \
--cc=fiona.klute@gmx.de \
--cc=ju.o@free.fr \
--cc=ricardo.martincoski@datacom.com.br \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox