From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claus Klein <claus.klein@arcormail.de>
Date: Fri, 19 Jan 2007 19:12:49 +0100
Subject: [Buildroot] package makefile conventions
Message-ID: <200701191912.49618.claus.klein@arcormail.de>
List-Id: <buildroot.busybox.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: buildroot@busybox.net

Hallo,

I found some packages which does not implement all needed targets.
Too, some of them use 'make' or 'sed' without the common make variable.

Last, but not least, why is '$(MAKE1)' used in some package makefiles?

ck

claus at P3linux:~/src/buildroot> ./mklint
package/gmp/gmp.mk lacks target gmp
package/gmp/gmp.mk lacks target gmp-source
package/gmp/gmp.mk lacks target gmp-clean
package/gmp/gmp.mk lacks target gmp-dirclean
package/qte/qte.mk lacks target qte-source
package/bash/bash.mk uses MAKE1 make var, why not $(MAKE) ?
package/dash/dash.mk uses MAKE1 make var, why not $(MAKE) ?
package/flex/flex.mk uses MAKE1 make var, why not $(MAKE) ?
package/lzma/lzma.mk lacks target lzma
package/mpfr/mpfr.mk lacks target mpfr
package/mpfr/mpfr.mk lacks target mpfr-source
package/mpfr/mpfr.mk lacks target mpfr-clean
package/mpfr/mpfr.mk lacks target mpfr-dirclean
package/pppd/pppd.mk uses MAKE1 make var, why not $(MAKE) ?
package/ipsec-tools/ipsec-tools.mk uses make without make var $(MAKE) /!\
package/expat/expat.mk lacks target expat-dirclean
package/pango/pango.mk uses MAKE1 make var, why not $(MAKE) ?
package/slang/slang.mk uses MAKE1 make var, why not $(MAKE) ?
package/wireless-tools/wireless-tools.mk uses sed without make var $(SED) :-(
package/iptables/iptables.mk uses MAKE1 make var, why not $(MAKE) ?
package/modutils/modutils.mk uses MAKE1 make var, why not $(MAKE) ?
package/ltp-testsuite/ltp-testsuite.mk uses MAKE1 make var, why not $(MAKE) ?
package/dmraid/dmraid.mk uses MAKE1 make var, why not $(MAKE) ?
package/ncurses/ncurses.mk uses MAKE1 make var, why not $(MAKE) ?
package/netsnmp/netsnmp.mk uses MAKE1 make var, why not $(MAKE) ?
package/pciutils/pciutils.mk uses MAKE1 make var, why not $(MAKE) ?
package/libelf/libelf.mk uses MAKE1 make var, why not $(MAKE) ?
package/libusb/libusb.mk uses make without make var $(MAKE) /!\
package/python/python.mk uses make without make var $(MAKE) /!\
package/e2fsprogs/e2fsprogs.mk uses MAKE1 make var, why not $(MAKE) ?
package/thttpd/thttpd.mk uses sed without make var $(SED) :-(
package/openntpd/openntpd.mk lacks target openntpd
package/openntpd/openntpd.mk lacks target openntpd-source
package/openntpd/openntpd.mk lacks target openntpd-clean
package/openntpd/openntpd.mk lacks target openntpd-dirclean
package/raidtools/raidtools.mk lacks target raidtools
package/raidtools/raidtools.mk lacks target raidtools-source
package/raidtools/raidtools.mk lacks target raidtools-clean
package/raidtools/raidtools.mk lacks target raidtools-dirclean
package/usbutils/usbutils.mk uses make without make var $(MAKE) /!\
package/openssl/openssl.mk uses MAKE1 make var, why not $(MAKE) ?
package/libevent/libevent.mk uses make without make var $(MAKE) /!\
package/libfloat/libfloat.mk uses make without make var $(MAKE) /!\
package/xfsprogs/xfsprogs.mk uses MAKE1 make var, why not $(MAKE) ?
package/microperl/microperl.mk uses make without make var $(MAKE) /!\
package/readline/readline.mk uses MAKE1 make var, why not $(MAKE) ?
package/asterisk/asterisk.mk uses MAKE1 make var, why not $(MAKE) ?
claus at P3linux:~/src/buildroot>            
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mklint
Type: application/x-shellscript
Size: 1819 bytes
Desc: not available
Url : http://busybox.net/lists/buildroot/attachments/20070119/400fcdbd/attachment.bin