Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Bernhard Fischer <rep.dot.nop@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] GCC version detection in toolchain/gcc/Makefile.in
Date: Fri, 30 Mar 2007 20:34:59 +0200	[thread overview]
Message-ID: <20070330183459.GB22338@aon.at> (raw)
In-Reply-To: <a04f56da0703290736x257e4f8aqb968db9a2402e06c@mail.gmail.com>

On Thu, Mar 29, 2007 at 10:36:27AM -0400, Zachary P. Landau wrote:
>Hello,
>
>I think there may be a problem in the GCC version detection code
>inside of toolchain/gcc/Makefile.in, but I wanted to verify it with
>people before filing a bug.  I am looking at the latest checkin of
>Makefile.in (revision 17836).
>
>Inside of that file, it uses the line: "ifeq ($(findstring
>3.4.,$(GCC_VERSION)),3.4.)" to detect gcc version 3.4.X.  But then a
>few lines down, in a separate ifeq, it uses the line: "ifeq
>($(findstring 4.,$(GCC_VERSION)),4.)".  I believe this is supposed to
>detect version "4.X.X" of GCC.  But it also seems to match 3.4.X
>(because that also has '4.' in it.
>
>This caused an issue for me when trying to compile openssl with gcc
>3.4.6.  The incorrect TARGET_SOFT_FLOAT option was being used because
>the "4." detection was overwriting the correct value detected a few
>lines above.
>
>Am I right that this is an issue, or am I missing something?

That sounds plausible, yes.
What do you suggest to distinguish between gcc version 4.4.9 and 3.4.6?

  reply	other threads:[~2007-03-30 18:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-29 14:36 [Buildroot] GCC version detection in toolchain/gcc/Makefile.in Zachary P. Landau
2007-03-30 18:34 ` Bernhard Fischer [this message]
2007-03-30 20:16   ` Zachary P. Landau
  -- strict thread matches above, loose matches on Subject: below --
2007-03-30 23:25 don
2007-04-02 13:50 ` Zachary P. Landau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070330183459.GB22338@aon.at \
    --to=rep.dot.nop@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox