Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: jacmet at uclibc.org <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] svn commit: trunk/buildroot/package/ethtool
Date: Thu, 31 May 2007 08:27:05 -0700 (PDT)	[thread overview]
Message-ID: <20070531152705.C8459485B1@busybox.net> (raw)

Author: jacmet
Date: 2007-05-31 08:27:05 -0700 (Thu, 31 May 2007)
New Revision: 18711

Log:
Cleanup, get rid of ETHTOOL_WORKDIR, use $@

Modified:
   trunk/buildroot/package/ethtool/ethtool.mk


Changeset:
Modified: trunk/buildroot/package/ethtool/ethtool.mk
===================================================================
--- trunk/buildroot/package/ethtool/ethtool.mk	2007-05-31 15:19:37 UTC (rev 18710)
+++ trunk/buildroot/package/ethtool/ethtool.mk	2007-05-31 15:27:05 UTC (rev 18711)
@@ -7,8 +7,7 @@
 ETHTOOL_VERSION=3
 ETHTOOL_SOURCE=ethtool-$(ETHTOOL_VERSION).tar.gz
 ETHTOOL_SITE=http://$(BR2_SOURCEFORGE_MIRROR).dl.sourceforge.net/sourceforge/gkernel/
-ETHTOOL_DIR=$(BUILD_DIR)/${shell basename $(ETHTOOL_SOURCE) .tar.gz}
-ETHTOOL_WORKDIR=$(BUILD_DIR)/ethtool-$(ETHTOOL_VERSION)
+ETHTOOL_DIR=$(BUILD_DIR)/ethtool-$(ETHTOOL_VERSION)
 ETHTOOL_CAT:=$(ZCAT)
 
 $(DL_DIR)/$(ETHTOOL_SOURCE):
@@ -16,7 +15,7 @@
 
 $(ETHTOOL_DIR)/.unpacked: $(DL_DIR)/$(ETHTOOL_SOURCE)
 	$(ETHTOOL_CAT) $(DL_DIR)/$(ETHTOOL_SOURCE) | tar -C $(BUILD_DIR) $(TAR_OPTIONS) -
-	touch $(ETHTOOL_DIR)/.unpacked
+	touch $@
 
 $(ETHTOOL_DIR)/.configured: $(ETHTOOL_DIR)/.unpacked
 	(cd $(ETHTOOL_DIR); rm -rf config.cache; \
@@ -30,26 +29,24 @@
 		--prefix=/usr \
 		--sysconfdir=/etc \
 	);
-	touch $(ETHTOOL_DIR)/.configured
+	touch $@
 
-$(ETHTOOL_WORKDIR)/ethtool: $(ETHTOOL_DIR)/.configured
-	$(MAKE) CC=$(TARGET_CC) -C $(ETHTOOL_WORKDIR)
+$(ETHTOOL_DIR)/ethtool: $(ETHTOOL_DIR)/.configured
+	$(MAKE) CC=$(TARGET_CC) -C $(ETHTOOL_DIR)
 
-$(ETHTOOL_WORKDIR)/.installed: $(ETHTOOL_WORKDIR)/ethtool
-	cp $(ETHTOOL_WORKDIR)/ethtool $(TARGET_DIR)/usr/sbin
-	touch $(ETHTOOL_WORKDIR)/.installed
+$(ETHTOOL_DIR)/.installed: $(ETHTOOL_DIR)/ethtool
+	cp $(ETHTOOL_DIR)/ethtool $(TARGET_DIR)/usr/sbin
+	touch $@
 
-ethtool:	uclibc $(ETHTOOL_WORKDIR)/.installed
+ethtool:	uclibc $(ETHTOOL_DIR)/.installed
 
 ethtool-source: $(DL_DIR)/$(ETHTOOL_SOURCE)
 
 ethtool-clean:
-	@if [ -d $(ETHTOOL_WORKDIR)/Makefile ] ; then \
-		$(MAKE) -C $(ETHTOOL_WORKDIR) clean ; \
-	fi;
+	-$(MAKE) -C $(ETHTOOL_DIR) clean
 
 ethtool-dirclean:
-	rm -rf $(ETHTOOL_DIR) $(ETHTOOL_WORKDIR)
+	rm -rf $(ETHTOOL_DIR)
 #############################################################
 #
 # Toplevel Makefile options

             reply	other threads:[~2007-05-31 15:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-31 15:27 jacmet at uclibc.org [this message]
  -- strict thread matches above, loose matches on Subject: below --
2007-08-01  9:53 [Buildroot] svn commit: trunk/buildroot/package/ethtool jacmet at uclibc.org
2008-06-26  6:50 hamish at uclibc.org
2008-08-04 19:07 jacmet at uclibc.org
2008-08-04 19:08 jacmet at uclibc.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070531152705.C8459485B1@busybox.net \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox