From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bernhard Fischer Date: Mon, 9 Jul 2007 10:25:50 +0200 Subject: [Buildroot] $(TARGET_CONFIGURE_OPTS) $(MAKE) vs $(MAKE) $(TARGET_CONFIGURE_OPTS) In-Reply-To: <05fb01c7c0e9$275c45a0$dcc4af0a@atmel.com> References: <006201c7bfd9$de0f46a0$dcc4af0a@atmel.com> <20070706155558.GA18954@real.realitydiluted.com> <000201c7c087$9e70d0a0$dcc4af0a@atmel.com> <20070707130132.GU4096@aon.at> <1183824383.19912.5.camel@elrond.sweden.atmel.com> <20070707172925.GV4096@aon.at> <1183837025.19912.17.camel@elrond.sweden.atmel.com> <20070707211606.GZ4096@aon.at> <05fb01c7c0e9$275c45a0$dcc4af0a@atmel.com> Message-ID: <20070709082550.GA19774@aon.at> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net On Sun, Jul 08, 2007 at 12:49:20AM +0200, Ulf Samuelsson wrote: >> On Sat, Jul 07, 2007 at 09:37:05PM +0200, Ulf Samuelsson wrote: >>>l?r 2007-07-07 klockan 19:29 +0200 skrev Bernhard Fischer: >>>> On Sat, Jul 07, 2007 at 06:06:23PM +0200, Ulf Samuelsson wrote: >>>> >> >I think someone got it wrong in the "package/mtd/mtd.mk" which says >>>> >> > >>>> >> > $(TARGET_CONFIGURE_OPTS) $(MAKE) ... - build using gcc >>>> >> > >>>> >> >which should be: >>>> >> > >>>> >> > $(MAKE) $(TARGET_CONFIGURE_OPTS) ... - build using arm-linux-uclibc-gcc >>>> >> >>>> >> yes, the latter is correct. Steven, please repair or elaborate. >>>> >> >>>> > >>>> >Here are a set of patches to change the position of >>>> >TARGET_CONFIGURE_OPTS. >>>> >Please review and apply if you agree. >>>> > >>>> > >>> > >Stephen, can you pls review the mtd part of this patch ASAP, >since this breaks the build for ARM (and possibly all non-x86). >Pls commit (or ack my commit) if OK. I've applied this now and will fix the other breakage due to not passing CFLAGS any longer, thus building with package-imposed incorrect flags.