Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Bernhard Fischer <rep.dot.nop@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] $(TARGET_CONFIGURE_OPTS) $(MAKE) vs $(MAKE) $(TARGET_CONFIGURE_OPTS)
Date: Tue, 10 Jul 2007 20:24:09 +0200	[thread overview]
Message-ID: <20070710182409.GA2880@aon.at> (raw)
In-Reply-To: <f0528b5b0707100451h758a3c44w8e1ba12dacd591bf@mail.gmail.com>

On Tue, Jul 10, 2007 at 01:51:52PM +0200, Julien Letessier wrote:

>Again, IMO very few (~10) packages will need to be fixed, so I'd prefer
>patching the packages themselves. Besides, most of them *are* fixed already.

I looked a little bit and it merely sounds like we could perhaps get
away with drop flags from TARGET_CONFIGURE_OPTS and pass (let's say)
TARGET_CONFIGURE_FLAGS to properly behaving packages and do obscure
workarounds for the few remaining packages that don't get their act
straight.
>
>If the only flag problem is the -O* problem, fixing the cross-compiler might
>be an option... except that GCC (especially the 4.2 branch) has a lot of
>regressions with -Os. Even though no bad code will be generated (AFAIK),
>some sources will crash the compiler, others will take any non-reasonable
>amount of time/memory to compile. E.g. xf86ScanPci.c in the X server
>requires >5GB of memory and about forever to compile on my build host with
>-Os (for no apparent reason).

heh, glad that i don't do X11 ;)
Still, can you please file a bug in gcc.gnu.org/bugzilla with the
preprocessed source of that file? TIA
>
>Besides, there are other flags to take care of... once we've started a list
>of flags to 'force' gcc to use, this will never be over. Why not forcing the
>compiler to use -mcpu=$(SUBARCH), -g, ad lib.

I occasionally do this to raise my blood pressure and to start endless
cursing about broken stuff, yea :/

A first step would be to explicitely do
Index: package/Makefile.in
===================================================================
--- package/Makefile.in (revision 19057)
+++ package/Makefile.in (working copy)
@@ -29,6 +29,22 @@
 #TARGET_LDFLAGS=-Wl,$(BR2_SYSROOT)
 endif
 
+CC_TARGET_TUNE_:=$(strip $(subst ",,BR2_GCC_TARGET_TUNE))
+#"))
+CC_TARGET_ARCH_:=$(strip $(subst ",,BR2_GCC_TARGET_ARCH))
+#"))
+CC_TARGET_ABI_:=$(strip $(subst ",,BR2_GCC_TARGET_ABI))
+#"))
+ifneq ($(CC_TARGET_TUNE_),)
+TARGET_CFLAGS+=-mtune=$(CC_TARGET_TUNE_)
+endif
+ifneq ($(CC_TARGET_ARCH_),)
+TARGET_CFLAGS+=-march=$(CC_TARGET_ARCH_)
+endif
+ifneq ($(CC_TARGET_ABI_),)
+TARGET_CFLAGS+=-mabi=$(CC_TARGET_ABI_)
+endif
+
 ifneq ($(BR2_PREFER_STATIC_LIB),y)
 ifeq ($(BR2_x86_64),y)
 TARGET_CFLAGS+=-fPIC -DPIC


but i recently changed the cross-compiler to default to this, so it's
really superfluous. An approach that would be even more evil (the above
will not catch folks on a compatible host) would be to make the
cross-compiler accept -fuxored-up-package and pass that ;)

  reply	other threads:[~2007-07-10 18:24 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-06 12:35 [Buildroot] What is the proper procedure to commit a patch? Ulf Samuelsson
2007-07-06 15:26 ` Bernhard Fischer
2007-07-06 15:36   ` Ulf Samuelsson
2007-07-07 10:12     ` Bernhard Fischer
2007-07-07 11:16       ` Ulf Samuelsson
2007-07-07 12:35         ` Bernhard Fischer
2007-07-07 13:46           ` Ulf Samuelsson
2007-07-06 15:55 ` Steven J. Hill
2007-07-06 21:10   ` Ulf Samuelsson
2007-07-07 10:06   ` [Buildroot] $(TARGET_CONFIGURE_OPTS) $(MAKE) vs $(MAKE) $(TARGET_CONFIGURE_OPTS) Ulf Samuelsson
2007-07-07 13:01     ` Bernhard Fischer
2007-07-07 16:06       ` Ulf Samuelsson
2007-07-07 17:29         ` Bernhard Fischer
2007-07-07 19:37           ` Ulf Samuelsson
2007-07-07 21:16             ` Bernhard Fischer
2007-07-07 22:49               ` Ulf Samuelsson
2007-07-09  8:25                 ` Bernhard Fischer
2007-07-09  9:21                   ` Bernhard Fischer
2007-07-09 12:20                     ` Steven J. Hill
2007-07-09 13:41                       ` Julien Letessier
2007-07-09 13:08                         ` Ulf Samuelsson
2007-07-09 16:33                         ` Bernhard Fischer
2007-07-10 11:51                           ` Julien Letessier
2007-07-10 18:24                             ` Bernhard Fischer [this message]
2007-07-07 10:21 ` [Buildroot] What is the proper procedure to commit a patch? Bernhard Fischer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070710182409.GA2880@aon.at \
    --to=rep.dot.nop@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox