Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Bernhard Fischer <rep.dot.nop@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] svn commit: trunk/buildroot: package package/busybox project target/ etc...
Date: Thu, 12 Jul 2007 16:42:44 +0200	[thread overview]
Message-ID: <20070712144244.GB21387@aon.at> (raw)
In-Reply-To: <20070712131106.1E690A4757@busybox.net>

On Thu, Jul 12, 2007 at 06:11:06AM -0700, ulf at uclibc.org wrote:
>Author: ulf
>Date: 2007-07-12 06:11:03 -0700 (Thu, 12 Jul 2007)
>New Revision: 19070

>Modified: trunk/buildroot/Makefile
>===================================================================
>--- trunk/buildroot/Makefile	2007-07-12 00:59:00 UTC (rev 19069)
>+++ trunk/buildroot/Makefile	2007-07-12 13:11:03 UTC (rev 19070)
>@@ -155,6 +155,12 @@
> else
> TARGETS:=uclibc
> endif
>+
>+PROJECT:=$(strip $(subst ",, $(BR2_PROJECT)))
>+HOSTNAME:=$(strip $(subst ",, $(BR2_HOSTNAME)))
>+BANNER:=$(strip $(subst ",, $(BR2_BANNER)))

This breaks vi's syntax highlighing, please fix
Also, you're aware that HOSTNAME previously was set to the hostname of
the build host and you just broke this, aren't you?

>Added: trunk/buildroot/project/Config.in
>===================================================================
>--- trunk/buildroot/project/Config.in	                        (rev 0)
>+++ trunk/buildroot/project/Config.in	2007-07-12 13:11:03 UTC (rev 19070)
>@@ -0,0 +1,26 @@
>+menu "Project Options"
>+
>+config BR2_PROJECT
>+	string "Project name"
>+	default "uclibc"
>+	help
>+	  The project name is used to define subdirectories
>+	  * where the Board Support Packages are built
>+	    (Linux,Root fs Bootmonitor,Utilities etc.)

whitespace dammaged CSVs

Please add inline documentation to PROJECT_BUILD_DIR and BUILD_DIR

  parent reply	other threads:[~2007-07-12 14:42 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-12 13:11 [Buildroot] svn commit: trunk/buildroot: package package/busybox project target/ etc ulf at uclibc.org
2007-07-12 13:25 ` Steven J. Hill
2007-07-12 11:58   ` Ulf Samuelsson
2007-07-12 12:15   ` Ulf Samuelsson
2007-07-12 14:02     ` Alexander Kriegisch
2007-07-12 14:32     ` Bernhard Fischer
2007-07-12 14:42 ` Bernhard Fischer [this message]
2007-07-12 13:56   ` Ulf Samuelsson
2007-07-12 15:51     ` Yann E. MORIN
2007-07-12 16:24       ` [Buildroot] svn commit: trunk/buildroot: package?package/busybox " Bernhard Fischer
2007-07-12 16:39         ` Yann E. MORIN
2007-07-12 17:51         ` Benjamin Tietz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070712144244.GB21387@aon.at \
    --to=rep.dot.nop@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox