Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Bernhard Fischer <rep.dot.nop@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] _VER vs. _VERSION breakage
Date: Mon, 23 Jul 2007 11:52:43 +0200	[thread overview]
Message-ID: <20070723095243.GC6597@aon.at> (raw)
In-Reply-To: <1184615647.18357.27.camel@elrond.sweden.atmel.com>

On Mon, Jul 16, 2007 at 09:54:06PM +0200, Ulf Samuelsson wrote:
>s?n 2007-07-15 klockan 12:40 +0200 skrev Bernhard Fischer:
>> Ulf,
>> 
>> Your change to use _VERSION broke at least acpid. Please double-check
>> that all packages that you touched in this patch still build fine and
>> repair.
>
>Here is the result of trying to build most available packages
>in buildroot for ARM. (I build for ARM generic (not using WCHAR)).

I will revert that _VERSION vs. _VER patch since it breaks a couple of
packages.
>
>A lot of the packages does not build for ARM,

Could be. For changes like _VER vs. _VERSION, a quick check with an x86
build before and after such a change would have been the proper thing to
do, imho.

>but if you can download the package, decompress it
>in build_<arch> and then configure or patch it, 
>then the VERSION patch is OK for this package.

>At least some of the packages seems to require the uClibc is 
>built with WCHAR. We should probably identify these packages
>and hide them during configuration if WCHAR is not enabled.

Yes, this is a completely different issue, though.

>
>Some packages like ACPID does not build for ARM
>but I think I got that right anyway, even if I did not try that
>specific package.
>Maybe someone building x86 can report the few packages
>I have problems with on ARM?

No need, i'll revert said patch and let those who want such a patch to
go in check if they break something.

Breaking the build for cosmetic reasons is not a sensible thing to do.

  reply	other threads:[~2007-07-23  9:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-15 10:40 [Buildroot] _VER vs. _VERSION breakage Bernhard Fischer
2007-07-16 19:54 ` Ulf Samuelsson
2007-07-23  9:52   ` Bernhard Fischer [this message]
2007-07-23 10:20     ` Ulf Samuelsson
2007-07-23 10:22     ` Cristian Ionescu-Idbohrn
2007-07-23 11:04       ` Bernhard Fischer
2007-07-23 12:05         ` Ulf Samuelsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070723095243.GC6597@aon.at \
    --to=rep.dot.nop@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox