Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Bernhard Fischer <rep.dot.nop@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] PATCH [1/2] try2: make Makefile.autotools.in not	to use hardcoded x11r7 name when patching
Date: Sat, 29 Sep 2007 00:40:19 +0200	[thread overview]
Message-ID: <20070928224019.GG20951@aon.at> (raw)
In-Reply-To: <46FD8D6A.40605@promwad.com>

On Sat, Sep 29, 2007 at 02:25:30AM +0300, Ivan Kuten wrote:
>> This may be obvious from the context, but is @D guaranteed to exist?
>
>Not sure - need take a look.
>
>2nd try, introducing DIR_PREFIX:

Excellent, thanks!

I come to think that a _DIR_SUFFIX for the patch-dir may
be needed also (if we have an occurrance in the tree already, that is.
No need to introduce this prematurely). I'm currently not aware of such
packages, though.

One nice example that, if it is handled properly by the autotools.in is
package/gmp or mpfr for that matter.

This package shows nicely what the autotools.in should provide in the
long run:
- downloading a PATCH_FILE to the dl/
- patching package/$name/$name$version
  or 
  patching package/$name/$version
  or 
  patching package/$name/$($(name)_patch_regex)
  or the like
- in configure, honor PREFERRED_LIB_FLAGS et al
- $(STRIP) the target, perhaps. Distinguish between binaries and libs
- optionally install headers if BR2_HAVE_HEADERS
- package-specific additional {C,LD,CPP,...}FLAGS
- package-specific additional configure-opts
- knowledge if both staging and target or only one of these should be
  populated with libs/binaries

  reply	other threads:[~2007-09-28 22:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-28 21:23 [Buildroot] PATCH [1/2] make Makefile.autotools.in not to use hardcoded x11r7 name when patching Ivan Kuten
2007-09-28 20:36 ` Bernhard Fischer
2007-09-28 23:25   ` [Buildroot] PATCH [1/2] try2: " Ivan Kuten
2007-09-28 22:40     ` Bernhard Fischer [this message]
2007-09-28 23:51       ` Ivan Kuten

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070928224019.GG20951@aon.at \
    --to=rep.dot.nop@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox