[Buildroot] gcc 4.2.2 patch

[Bernhard Fischer <rep.dot.nop@gmail.com>]

On Fri, Mar 28, 2008 at 09:03:42PM +0000, Nigel Kukard wrote:
>> close.
>> Correct would have been to use $(INSTALL). Also the for loop doesn't
>> make too much sense, fwiw.
>> 
>> Something like this should do everything that is needed and is not
>> bloated:
>> 	$(INSTALL) -D -m0755 $(patsubst %,$(STAGING_DIR)/sbin/%,$(LVM2_SBIN)) $(TARGET_DIR)/sbin/
>> 
>> Remember that this is *make* and not your favourite shell..
>
>Thanks, I'll keep that in mind. I've found quite a number of for's in
>the tree, if I come across them again I'll fix it.

Fair enough, but it would be nicer if you would take it upon you to fix
them in one sweep and once and for all. Every such occurance should be
fixed and no new occurance (or touch thereof) should be accepted into
the tree.
Same with all those (="??%?) touch /the/make_target. There is $@ and it
should be used for the sake of cleanlyness. I could go on with another
handful of such cruft but you get the idea..