From: Bernhard Fischer <rep.dot.nop@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] svn commit: trunk/buildroot/package/valgrind
Date: Mon, 16 Jun 2008 09:54:21 +0200 [thread overview]
Message-ID: <20080616075421.GB19499@mx.loc> (raw)
In-Reply-To: <20080615204411.C28F33C937@busybox.net>
On Sun, Jun 15, 2008 at 01:44:11PM -0700, jacmet at uclibc.org wrote:
>Author: jacmet
>Date: 2008-06-15 13:44:10 -0700 (Sun, 15 Jun 2008)
>New Revision: 22360
>
>Log:
>valgrind: don't add pkgconfig files to target
>
>
>Modified:
> trunk/buildroot/package/valgrind/valgrind.mk
>
>
>Changeset:
>Modified: trunk/buildroot/package/valgrind/valgrind.mk
>===================================================================
>--- trunk/buildroot/package/valgrind/valgrind.mk 2008-06-15 20:44:05 UTC (rev 22359)
>+++ trunk/buildroot/package/valgrind/valgrind.mk 2008-06-15 20:44:10 UTC (rev 22360)
>@@ -64,6 +64,7 @@
-> cp package/valgrind/valgrind.sh $(TARGET_DIR)/usr/bin/valgrind
$(INSTALL)
> chmod a+x $(TARGET_DIR)/usr/bin/valgrind
> rm -rf $(TARGET_DIR)/usr/share/doc/valgrind
>+ rm -rf $(TARGET_DIR)/usr/lib/pkgconfig
Removing all is a bit generic, no? Think about somebody selecting
pkgconfig for the target. If i would do this, i would expect
$(TARGET_DIR)/usr/lib/pkgconfig to be populated and useable..
> #mkdir -p $(TARGET_DIR)/etc/default
> #cp $(VALGRIND_DIR)/valgrind.default $(TARGET_DIR)/etc/default/valgrind
> #mkdir -p $(TARGET_DIR)/usr/lib/valgrind
cruft. Should have used
$(INSTALL) -D $(VALGRIND_DIR)/valgrind.default $(TARGET_DIR)/etc/default/valgrind
anyway.
next prev parent reply other threads:[~2008-06-16 7:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-15 20:44 [Buildroot] svn commit: trunk/buildroot/package/valgrind jacmet at uclibc.org
2008-06-16 7:54 ` Bernhard Fischer [this message]
2008-06-16 8:03 ` Peter Korsgaard
-- strict thread matches above, loose matches on Subject: below --
2008-07-01 19:09 jacmet at uclibc.org
2008-06-15 20:44 jacmet at uclibc.org
2008-06-15 19:17 jacmet at uclibc.org
2007-07-05 15:55 jacmet at uclibc.org
2007-04-03 15:36 jacmet at uclibc.org
2006-09-25 8:48 jacmet at uclibc.org
2006-09-25 7:27 jacmet at uclibc.org
2006-08-10 20:21 andersen at uclibc.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080616075421.GB19499@mx.loc \
--to=rep.dot.nop@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox